[RFC] clean up headers for light drivers : backlights, leds and iio-light

[RFC] clean up headers for light drivers : backlights, leds and iio-light

[Kim, Milo]

I'd like to suggest some clean up idea for headers under include/linux.
Light device drivers are exist under 'drivers/leds' and 'drivers/video/backlight'.
(and iio light drivers are ongoing in staging directory)
At this moment, there is no specific directory for light driver, some headers are located in include/linux.
Furthermore, new light drivers may be added into include/linux again and again.

So my suggestion is 

- create new directory for light driver : include/linux/light
- move driver headers into this directory
- change header declaration per each driver source

Here is the cleanup list of light drivers.

(leds and backlight)
include/linux/apple_bl.h
include/linux/atmel_pwm.h
include/linux/backlight.h
include/linux/led-lm3530.h
include/linux/leds-bd2802.h
include/linux/leds.h
include/linux/leds-lm3556.h
include/linux/leds-lp3944.h
include/linux/leds-lp5521.h
include/linux/leds-lp5523.h
include/linux/leds-pca9532.h
include/linux/leds_pwm.h
include/linux/leds-regulator.h
include/linux/leds-tca6507.h
include/linux/lp855x.h
include/linux/pwm_backlight.h

(iio/backlight)
drivers/staging/iio/light/tsl2563.h
drivers/staging/iio/light/tsl2x7x.h

I'd like to have your opinion.

Thanks & BR
Milo -

Re: [RFC] clean up headers for light drivers : backlights, leds and iio-light

[gregkh]

On Tue, Jun 05, 2012 at 03:43:08PM +0000, Kim, Milo wrote:
> I'd like to suggest some clean up idea for headers under include/linux.
> Light device drivers are exist under 'drivers/leds' and 'drivers/video/backlight'.
> (and iio light drivers are ongoing in staging directory)
> At this moment, there is no specific directory for light driver, some headers are located in include/linux.
> Furthermore, new light drivers may be added into include/linux again and again.

Why do any of these need .h files in include/linux/ in the first place?

> So my suggestion is 
> 
> - create new directory for light driver : include/linux/light
> - move driver headers into this directory
> - change header declaration per each driver source
> 
> Here is the cleanup list of light drivers.
> 
> (leds and backlight)
> include/linux/apple_bl.h
> include/linux/atmel_pwm.h
> include/linux/backlight.h
> include/linux/led-lm3530.h
> include/linux/leds-bd2802.h
> include/linux/leds.h
> include/linux/leds-lm3556.h
> include/linux/leds-lp3944.h
> include/linux/leds-lp5521.h
> include/linux/leds-lp5523.h
> include/linux/leds-pca9532.h
> include/linux/leds_pwm.h
> include/linux/leds-regulator.h
> include/linux/leds-tca6507.h
> include/linux/lp855x.h
> include/linux/pwm_backlight.h

Lots of those can move to include/linux/platform_data/ today, which
would clean up things a lot.  Care to do that first and see what is left
over and is really needed here?

thanks,

greg k-h

RE: [RFC] clean up headers for light drivers : backlights, leds and iio-light

[Kim, Milo]

> Lots of those can move to include/linux/platform_data/ today, which
> would clean up things a lot.  Care to do that first and see what is
> left
> over and is really needed here?

OK, I'll keep tracking first.
Thanks for your opinion.

Best Regards,
Milo -