From: Fabio Baltieri <fabio.baltieri@gmail.com>
To: Bryan Wu <bryan.wu@canonical.com>
Cc: Shuah Khan <shuahkhan@gmail.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Richard Purdie <rpurdie@rpsys.net>
Subject: Re: [PATCH 3/3] led: add oneshot trigger
Date: Tue, 5 Jun 2012 22:55:05 +0200 [thread overview]
Message-ID: <20120605205504.GA1350@gmail.com> (raw)
In-Reply-To: <CAK5ve-LS2qJKTihbdbhEnW3cOQzqB6phtJm0=Djt6znqwjf4CA@mail.gmail.com>
Hi Bryan,
On Tue, Jun 05, 2012 at 03:37:39PM +0800, Bryan Wu wrote:
> >
> > Ok, anyway as your patch has been mainlined and this (totally?) overlaps
> > with it I think it's ok to just use this to test the API of first patch
> > of this set.
> >
>
> Shuah's leds patches are all in mainline now. But I think this trigger
> is still useful for an good example to use the new API.
> And it is easy for user to use the oneshot trigger from here.
>
> I've already merged 2 patches from you, so if you like, please follow
> Shuah's advice to cleanup this trigger and resend.
Ok, I found another small bug so I'm sending a v2 patchest on a separate
thread for clearness.
Fabio
>
>
> --
> Bryan Wu <bryan.wu@canonical.com>
> Kernel Developer +86.186-168-78255 Mobile
> Canonical Ltd. www.canonical.com
> Ubuntu - Linux for human beings | www.ubuntu.com
next prev parent reply other threads:[~2012-06-05 20:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-26 23:19 [PATCH v2 1/3] leds: add oneshot blink functions Fabio Baltieri
2012-05-26 23:19 ` [PATCH 2/3] ledtrig-ide-disk: use generic one-shot blink api Fabio Baltieri
2012-06-05 7:20 ` Bryan Wu
2012-05-26 23:19 ` [PATCH 3/3] led: add oneshot trigger Fabio Baltieri
2012-05-27 16:09 ` Shuah Khan
2012-05-31 21:01 ` Fabio Baltieri
2012-06-05 7:37 ` Bryan Wu
2012-06-05 20:55 ` Fabio Baltieri [this message]
2012-05-27 16:13 ` [PATCH v2 1/3] leds: add oneshot blink functions Shuah Khan
2012-05-31 21:08 ` Fabio Baltieri
2012-06-01 15:39 ` Shuah Khan
2012-06-04 21:37 ` Fabio Baltieri
2012-06-04 23:12 ` Shuah Khan
2012-06-05 3:05 ` Bryan Wu
2012-06-05 14:59 ` Shuah Khan
2012-06-06 2:44 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120605205504.GA1350@gmail.com \
--to=fabio.baltieri@gmail.com \
--cc=bryan.wu@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=shuahkhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).