public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: David Rientjes <rientjes@google.com>
Cc: a.p.zijlstra@chello.nl, hpa@zytor.com,
	linux-kernel@vger.kernel.org, yinghai@kernel.org, tj@kernel.org,
	tglx@linutronix.de, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:sched/core] x86/numa: Allow specifying node_distance() for numa=fake
Date: Wed, 6 Jun 2012 09:11:17 +0200	[thread overview]
Message-ID: <20120606071117.GE17808@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1205311346490.2764@chino.kir.corp.google.com>


* David Rientjes <rientjes@google.com> wrote:

> On Wed, 9 May 2012, tip-bot for Peter Zijlstra wrote:
> 
> > Commit-ID:  94c0dd3278dd3eae52eabf0fb77d472d0dd3e373
> > Gitweb:     http://git.kernel.org/tip/94c0dd3278dd3eae52eabf0fb77d472d0dd3e373
> > Author:     Peter Zijlstra <a.p.zijlstra@chello.nl>
> > AuthorDate: Wed, 18 Apr 2012 19:04:17 +0200
> > Committer:  Ingo Molnar <mingo@kernel.org>
> > CommitDate: Wed, 9 May 2012 13:28:59 +0200
> > 
> > x86/numa: Allow specifying node_distance() for numa=fake
> > 
> > Allows emulating more interesting NUMA configurations like a quad
> > socket AMD Magny-Cour:
> > 
> >  "numa=fake=8:10,16,16,22,16,22,16,22,
> >               16,10,22,16,22,16,22,16,
> >               16,22,10,16,16,22,16,22,
> >               22,16,16,10,22,16,22,16,
> >               16,22,16,22,10,16,16,22,
> >               22,16,22,16,16,10,22,16,
> >               16,22,16,22,16,22,10,16,
> >               22,16,22,16,22,16,16,10"
> > 
> > Which has a non-fully-connected topology.
> > 
> 
> I like this support and I'm pretty sure you used it to 
> reproduce my problems with sched/numa locally, but I think it 
> would be better to seperate it out as a different parameter 
> such as slit=fake so that we can still use it to fake the SLIT 
> of our NUMA machines without requiring numa=fake which 
> provides no guarantees to break the nodes along physical 
> boundaries.
> 
> So without seperating it out into slit=fake, we can't change 
> this information without changing the SLIT itself and that 
> makes debugging harder.

Makes sense - wanna send a patch?

Thanks,

	Ingo

      reply	other threads:[~2012-06-06  7:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-09 12:58 [tip:sched/core] x86/numa: Allow specifying node_distance() for numa=fake tip-bot for Peter Zijlstra
2012-05-31 20:49 ` David Rientjes
2012-06-06  7:11   ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120606071117.GE17808@gmail.com \
    --to=mingo@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=rientjes@google.com \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox