From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757195Ab2FFQI5 (ORCPT ); Wed, 6 Jun 2012 12:08:57 -0400 Received: from one.firstfloor.org ([213.235.205.2]:54778 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756795Ab2FFQIz (ORCPT ); Wed, 6 Jun 2012 12:08:55 -0400 Date: Wed, 6 Jun 2012 18:08:48 +0200 From: Andi Kleen To: Peter Zijlstra Cc: Andi Kleen , Andi Kleen , linux-kernel@vger.kernel.org, eranian@google.com Subject: Re: [PATCH 1/5] perf, x86: Don't assume the alternative cycles encoding is architectural Message-ID: <20120606160848.GG27374@one.firstfloor.org> References: <1338944211-28275-1-git-send-email-andi@firstfloor.org> <1338979188.2749.92.camel@twins> <20120606141247.GD28225@tassilo.jf.intel.com> <1338992061.2749.111.camel@twins> <20120606142323.GG28225@tassilo.jf.intel.com> <1338992910.2749.121.camel@twins> <20120606143536.GH28225@tassilo.jf.intel.com> <1338993726.2749.125.camel@twins> <20120606144952.GK28225@tassilo.jf.intel.com> <1338994385.2749.130.camel@twins> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1338994385.2749.130.camel@twins> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 06, 2012 at 04:53:05PM +0200, Peter Zijlstra wrote: > > > So your patch would fix the problem iff you only fill in the pebs_aliases > > in the model number switch for known Core model numbers. > > + if (event->attr.precise_ip && x86_pmu.pebs_aliases) > + x86_pmu.pebs_aliases(event); > > Never happens, and we're happy again. How about newer unknown Intel CPUs with arch_perfmon >= 3? Those would get intel_pmu, correct? There's no guarantee that they support the trick. -Andi -- ak@linux.intel.com -- Speaking for myself only.