From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Tony Luck <tony.luck@intel.com>,
Borislav Petkov <borislav.petkov@amd.com>,
Chen Gong <gong.chen@linux.intel.com>,
x86@kernel.org, Peter Zijlstra <peterz@infradead.org>
Subject: [patch 1/5] x86: mce: Disable preemption when calling raise_local()
Date: Wed, 06 Jun 2012 21:53:22 -0000 [thread overview]
Message-ID: <20120606215116.480611718@linutronix.de> (raw)
In-Reply-To: 20120606214941.104735929@linutronix.de
[-- Attachment #1: x86-mce-disable-preemption-when-calling-raise-local.patch --]
[-- Type: text/plain, Size: 923 bytes --]
raise_mce() has a code path which does not disable preemption when the
raise_local() is called. The per cpu variable access in raise_local()
depends on preemption being disabled to be functional. So that code
path was either never tested or never tested with CONFIG_DEBUG_PREEMPT
enabled.
Add the missing preempt_disable/enable() pair around the call.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/kernel/cpu/mcheck/mce-inject.c | 4 ++++
1 file changed, 4 insertions(+)
Index: tip/arch/x86/kernel/cpu/mcheck/mce-inject.c
===================================================================
--- tip.orig/arch/x86/kernel/cpu/mcheck/mce-inject.c
+++ tip/arch/x86/kernel/cpu/mcheck/mce-inject.c
@@ -194,7 +194,11 @@ static void raise_mce(struct mce *m)
put_online_cpus();
} else
#endif
+ {
+ preempt_disable();
raise_local();
+ preempt_enable();
+ }
}
/* Error injection interface */
next prev parent reply other threads:[~2012-06-06 21:53 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 21:53 [patch 0/5] x86: mce: Bugfixes, cleanups and a new CMCI poll version Thomas Gleixner
2012-06-06 21:53 ` Thomas Gleixner [this message]
2012-06-06 21:53 ` [patch 2/5] x86: mce: Serialize mce injection Thomas Gleixner
2012-06-06 21:53 ` [patch 3/5] x86: mce: Split timer init Thomas Gleixner
2012-06-07 15:18 ` Borislav Petkov
2012-06-20 3:35 ` Hidetoshi Seto
2012-06-06 21:53 ` [patch 5/5] x86: mce: Add cmci poll mode Thomas Gleixner
2012-06-07 18:14 ` Borislav Petkov
2012-06-06 21:53 ` [patch 4/5] x86: mce: Remove the frozen cases in the hotplug code Thomas Gleixner
2012-06-07 17:49 ` Borislav Petkov
2012-06-07 10:08 ` [patch 0/5] x86: mce: Bugfixes, cleanups and a new CMCI poll version Chen Gong
2012-06-07 13:35 ` Borislav Petkov
2012-06-07 16:22 ` Luck, Tony
2012-06-08 7:49 ` Thomas Gleixner
2012-06-11 5:46 ` Chen Gong
2012-06-11 6:09 ` Chen Gong
2012-06-14 13:49 ` [PATCH] tmp patch to fix hotplug issue in CMCI storm Chen Gong
2012-06-14 14:07 ` Thomas Gleixner
2012-06-15 6:51 ` Chen Gong
2012-06-15 9:55 ` Thomas Gleixner
2012-06-18 6:42 ` Chen Gong
2012-06-18 6:45 ` [PATCH V2] " Chen Gong
2012-06-18 8:00 ` Thomas Gleixner
2012-06-18 10:13 ` Chen Gong
2012-06-18 12:23 ` Thomas Gleixner
2012-06-19 6:05 ` Chen Gong
2012-06-19 6:09 ` [PATCH V3] " Chen Gong
2012-07-04 8:12 ` Chen Gong
2012-07-16 3:16 ` Chen Gong
2012-07-16 8:22 ` Thomas Gleixner
2012-07-17 21:47 ` Chen Gong
-- strict thread matches above, loose matches on Subject: below --
2012-07-18 19:59 [V2] x86: mce: Bugfixes, cleanups and a new CMCI poll version Chen Gong
2012-07-18 19:59 ` [PATCH 1/5] x86: mce: Disable preemption when calling raise_local() Chen Gong
2012-07-19 17:59 [RESEND PATCH 0/5 V2] x86: mce: Bugfixes, cleanups and a new CMCI poll version Chen Gong
2012-07-19 17:59 ` [PATCH 1/5] x86: mce: Disable preemption when calling raise_local() Chen Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120606215116.480611718@linutronix.de \
--to=tglx@linutronix.de \
--cc=borislav.petkov@amd.com \
--cc=gong.chen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).