linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Tony Luck <tony.luck@intel.com>,
	Borislav Petkov <borislav.petkov@amd.com>,
	Chen Gong <gong.chen@linux.intel.com>,
	x86@kernel.org, Peter Zijlstra <peterz@infradead.org>
Subject: [patch 2/5] x86: mce: Serialize mce injection
Date: Wed, 06 Jun 2012 21:53:23 -0000	[thread overview]
Message-ID: <20120606215116.546087209@linutronix.de> (raw)
In-Reply-To: 20120606214941.104735929@linutronix.de

[-- Attachment #1: x86-mce-serialize-mce-injection.patch --]
[-- Type: text/plain, Size: 1006 bytes --]

raise_mce() fiddles with global state, but lacks any kind of
serialization.

Add a mutex around the raise_mce() call, so concurrent writers do not
stomp on each other toes.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/x86/kernel/cpu/mcheck/mce-inject.c |    4 ++++
 1 file changed, 4 insertions(+)

Index: tip/arch/x86/kernel/cpu/mcheck/mce-inject.c
===================================================================
--- tip.orig/arch/x86/kernel/cpu/mcheck/mce-inject.c
+++ tip/arch/x86/kernel/cpu/mcheck/mce-inject.c
@@ -78,6 +78,7 @@ static void raise_exception(struct mce *
 }
 
 static cpumask_var_t mce_inject_cpumask;
+static DEFINE_MUTEX(mce_inject_mutex);
 
 static int mce_raise_notify(unsigned int cmd, struct pt_regs *regs)
 {
@@ -229,7 +230,10 @@ static ssize_t mce_write(struct file *fi
 	 * so do it a jiffie or two later everywhere.
 	 */
 	schedule_timeout(2);
+
+	mutex_lock(&mce_inject_mutex);
 	raise_mce(&m);
+	mutex_unlock(&mce_inject_mutex);
 	return usize;
 }
 



  parent reply	other threads:[~2012-06-06 21:54 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-06 21:53 [patch 0/5] x86: mce: Bugfixes, cleanups and a new CMCI poll version Thomas Gleixner
2012-06-06 21:53 ` [patch 1/5] x86: mce: Disable preemption when calling raise_local() Thomas Gleixner
2012-06-06 21:53 ` Thomas Gleixner [this message]
2012-06-06 21:53 ` [patch 3/5] x86: mce: Split timer init Thomas Gleixner
2012-06-07 15:18   ` Borislav Petkov
2012-06-20  3:35   ` Hidetoshi Seto
2012-06-06 21:53 ` [patch 5/5] x86: mce: Add cmci poll mode Thomas Gleixner
2012-06-07 18:14   ` Borislav Petkov
2012-06-06 21:53 ` [patch 4/5] x86: mce: Remove the frozen cases in the hotplug code Thomas Gleixner
2012-06-07 17:49   ` Borislav Petkov
2012-06-07 10:08 ` [patch 0/5] x86: mce: Bugfixes, cleanups and a new CMCI poll version Chen Gong
2012-06-07 13:35   ` Borislav Petkov
2012-06-07 16:22     ` Luck, Tony
2012-06-08  7:49   ` Thomas Gleixner
2012-06-11  5:46     ` Chen Gong
2012-06-11  6:09     ` Chen Gong
2012-06-14 13:49     ` [PATCH] tmp patch to fix hotplug issue in CMCI storm Chen Gong
2012-06-14 14:07       ` Thomas Gleixner
2012-06-15  6:51         ` Chen Gong
2012-06-15  9:55           ` Thomas Gleixner
2012-06-18  6:42             ` Chen Gong
2012-06-18  6:45             ` [PATCH V2] " Chen Gong
2012-06-18  8:00               ` Thomas Gleixner
2012-06-18 10:13                 ` Chen Gong
2012-06-18 12:23                   ` Thomas Gleixner
2012-06-19  6:05                     ` Chen Gong
2012-06-19  6:09                     ` [PATCH V3] " Chen Gong
2012-07-04  8:12                       ` Chen Gong
2012-07-16  3:16                         ` Chen Gong
2012-07-16  8:22                           ` Thomas Gleixner
2012-07-17 21:47                             ` Chen Gong
  -- strict thread matches above, loose matches on Subject: below --
2012-07-18 19:59 [V2] x86: mce: Bugfixes, cleanups and a new CMCI poll version Chen Gong
2012-07-18 19:59 ` [PATCH 2/5] x86: mce: Serialize mce injection Chen Gong
2012-07-19 17:59 [RESEND PATCH 0/5 V2] x86: mce: Bugfixes, cleanups and a new CMCI poll version Chen Gong
2012-07-19 17:59 ` [PATCH 2/5] x86: mce: Serialize mce injection Chen Gong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120606215116.546087209@linutronix.de \
    --to=tglx@linutronix.de \
    --cc=borislav.petkov@amd.com \
    --cc=gong.chen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).