From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Bryan Freed <bfreed@chromium.org>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
linux-kernel@vger.kernel.org, keescook@chromium.org,
marco.stornelli@gmail.com, grant.likely@secretlab.ca
Subject: Re: [PATCH] pstore/ram: Add ramoops support for the Flattened Device Tree.
Date: Wed, 6 Jun 2012 15:05:29 -0700 [thread overview]
Message-ID: <20120606220528.GA4010@lizard> (raw)
In-Reply-To: <CAEYUcX33J4VjFOc1qLi7TZQ6B8ugc0Yky=pm1yPJXqi=SfZPBA@mail.gmail.com>
On Wed, Jun 06, 2012 at 11:00:27AM -0700, Bryan Freed wrote:
[...]
> Anyone have a strong feeling on dev_err vs pr_err and how/if this
> transition should occur?
If you have a device, it's better to use dev_*(), since that way
you'll get more information in the logs, e.g. which exact device
caused the issue.
But this makes sense only for drivers that support multiple
devices. Not the case for pstore now, though this might change
in the future. (E.g. we might have several pstore nodes some day.)
Thanks,
--
Anton Vorontsov
Email: cbouatmailru@gmail.com
next prev parent reply other threads:[~2012-06-06 22:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-05 19:59 [PATCH] pstore/ram: Add ramoops support for the Flattened Device Tree Bryan Freed
2012-06-06 17:16 ` Stephen Boyd
2012-06-06 18:00 ` Bryan Freed
2012-06-06 22:05 ` Anton Vorontsov [this message]
2012-06-07 22:22 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120606220528.GA4010@lizard \
--to=cbouatmailru@gmail.com \
--cc=bfreed@chromium.org \
--cc=grant.likely@secretlab.ca \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.stornelli@gmail.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox