From: Greg KH <gregkh@linuxfoundation.org>
To: stefani@seibold.net
Cc: linux-kernel@vger.kernel.org, oneukum@suse.de,
alan@lxorguk.ukuu.org.uk, linux-usb@vger.kernel.org
Subject: Re: [PATCH 04/11] remove usb_interface pointer
Date: Thu, 7 Jun 2012 07:54:26 +0900 [thread overview]
Message-ID: <20120606225426.GA8270@kroah.com> (raw)
In-Reply-To: <1339000032-10313-5-git-send-email-stefani@seibold.net>
On Wed, Jun 06, 2012 at 06:27:05PM +0200, stefani@seibold.net wrote:
> From: Stefani Seibold <stefani@seibold.net>
>
> this saves a litte bit of memory space in the driver devices structure
>
> Signed-off-by: Stefani Seibold <stefani@seibold.net>
> ---
> drivers/usb/usb-skeleton.c | 23 ++++++++++++-----------
> 1 files changed, 12 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c
> index 2f17991..f7fe32f 100644
> --- a/drivers/usb/usb-skeleton.c
> +++ b/drivers/usb/usb-skeleton.c
> @@ -49,7 +49,6 @@ MODULE_DEVICE_TABLE(usb, skel_table);
> /* Structure to hold all of our device specific stuff */
> struct usb_skel {
> struct usb_device *udev; /* the usb device for this device */
> - struct usb_interface *interface; /* the interface for this device */
No, that's the exact opposite of what I asked you to do.
next prev parent reply other threads:[~2012-06-06 22:54 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 16:27 [PATCH] fix usb skeleton driver stefani
2012-06-06 16:27 ` [PATCH 01/11] fix wrong label in skel_open stefani
2012-06-06 18:52 ` Oliver Neukum
2012-06-06 19:59 ` Stefani Seibold
2012-06-06 16:27 ` [PATCH 02/11] code cleanup stefani
2012-06-06 18:57 ` Oliver Neukum
2012-06-06 16:27 ` [PATCH 03/11] remove dead code stefani
2012-06-06 16:27 ` [PATCH 04/11] remove usb_interface pointer stefani
2012-06-06 18:59 ` Oliver Neukum
2012-06-06 20:04 ` Stefani Seibold
2012-06-06 20:19 ` Alan Stern
2012-06-06 22:54 ` Greg KH [this message]
2012-06-07 8:07 ` Stefani Seibold
2012-06-07 11:51 ` Stefani Seibold
2012-06-07 14:28 ` Alan Stern
2012-06-07 15:03 ` Stefani Seibold
2012-06-07 15:27 ` Alan Stern
2012-06-07 19:50 ` Stefani Seibold
2012-06-07 20:42 ` Alan Stern
2012-06-08 7:18 ` RFC: remove usb_device pointer from usb_skeleton.c Stefani Seibold
2012-06-08 8:28 ` Oliver Neukum
2012-06-08 13:46 ` Alan Stern
2012-06-06 16:27 ` [PATCH 05/11] remove unneeded forward declaration stefani
2012-06-06 16:27 ` [PATCH 06/11] introduce fsync function stefani
2012-06-06 16:27 ` [PATCH 07/11] remove pr_err() noise in skel_open stefani
2012-06-06 16:27 ` [PATCH 08/11] Handle a non blocking read without blocking stefani
2012-06-06 16:27 ` [PATCH 09/11] Synchronize disconnect() handler with open() and release(), to fix races stefani
2012-06-06 16:27 ` [PATCH 10/11] Introduce single user mode stefani
2012-06-06 16:27 ` [PATCH 11/11] Bump version number and add aditional author stefani
2012-06-06 16:55 ` [PATCH] fix usb skeleton driver Alan Stern
2012-06-06 17:53 ` Stefani Seibold
2012-06-06 18:16 ` Alan Stern
2012-06-06 20:19 ` Stefani Seibold
2012-06-06 20:22 ` Alan Stern
2012-06-07 8:13 ` Stefani Seibold
2012-06-07 7:10 ` Bjørn Mork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120606225426.GA8270@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.de \
--cc=stefani@seibold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox