From: Joerg Roedel <joerg.roedel@amd.com>
To: Shuah Khan <shuah.khan@hp.com>
Cc: <iommu@lists.linux-foundation.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC] iommu/amd: Fix missing iommu_shutdown initialization in passthrough mode
Date: Thu, 7 Jun 2012 11:32:35 +0200 [thread overview]
Message-ID: <20120607093235.GK757@amd.com> (raw)
In-Reply-To: <1339001406.2763.49.camel@lorien2>
On Wed, Jun 06, 2012 at 10:50:06AM -0600, Shuah Khan wrote:
> Change AMD iommu driver to call disable iommus in pass-through mode. AMD
> iommu driver's amd_iommu_init() routine doesn't initialize iommu_shutdown
> in pass-through mode. As a result iommu disable via a call to disable_iommus()
> doesn't happen at shutdown. Enable and disable of iommus is inconsistent in
> pass-through mode. IOMMU is enabled, but not disabled. IOMMU disable is called
> from error legs in amd_iommu_init() in pass-through mode.
>
> Requesting for comments as I don't have access to AMD system that supports
> IOMMU. I tested the change on AMD platforms with GART IOMMU which is not
> sufficient.
>
> Signed-off-by: Shuah Khan <shuah.khan@hp.com>
The patch is fine. Thanks, applied to iommu/fixes.
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
prev parent reply other threads:[~2012-06-07 9:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 16:50 [PATCH RFC] iommu/amd: Fix missing iommu_shutdown initialization in passthrough mode Shuah Khan
2012-06-07 9:32 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120607093235.GK757@amd.com \
--to=joerg.roedel@amd.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shuah.khan@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox