Re: [PATCH] inet: Initialize per-netns inetpeer roots in net/ipv{4,6}/route.c

Re: [PATCH] inet: Initialize per-netns inetpeer roots in net/ipv{4,6}/route.c

[Fengguang Wu]

On Sat, Jun 09, 2012 at 07:04:51PM -0700, David Miller wrote:
> From: Fengguang Wu <wfg@linux.intel.com>
> Date: Sun, 10 Jun 2012 09:58:32 +0800
> 
> > It triggers some warnings:
> > 
> > WARNING: net/ipv6/ipv6.o(.text+0x1049c): Section mismatch in reference from the function ip6_route_cleanup() to the variable .init.data:ipv6_inetpeer_ops
> 
> This should fix it:

Yes it worked.

Tested-by: Fengguang Wu <wfg@linux.intel.com>

In long run, such build-fix patches can also be auto tested and
reported, somehow in this way. You just create a temporary branch
named "0day-XXXXXX" and push the build-fix patch there. After a while
my robot script will pull and build test it. When finished, it will
recognize the "0day" pattern in the branch name and then
*unconditionally* report back.

"unconditionally" means it will

- report build failure as well as build success
- report new error/warnings as well as old ones

Upon receiving the success/failure notification, you can then proceed
to either merge the commit to the main branch, or update the commit in
place to restart the test. This should work much more fluently than
waiting for me to manually test some emailed patch. Not only I may be
sleeping at the time, but also I'm sending out build failure reports
almost *every day*. It would be a burden for me to manually test out
fixes every day...

Thanks,
Fengguang

Re: [PATCH] inet: Initialize per-netns inetpeer roots in net/ipv{4,6}/route.c

[David Miller]

From: Fengguang Wu <wfg@linux.intel.com>
Date: Sun, 10 Jun 2012 11:16:34 +0800

> In long run, such build-fix patches can also be auto tested and
> reported, somehow in this way. You just create a temporary branch

Sorry, no.

Re: [PATCH] inet: Initialize per-netns inetpeer roots in net/ipv{4,6}/route.c

[Fengguang Wu]

On Sat, Jun 09, 2012 at 09:21:47PM -0700, David Miller wrote:
> From: Fengguang Wu <wfg@linux.intel.com>
> Date: Sun, 10 Jun 2012 11:16:34 +0800
> 
> > In long run, such build-fix patches can also be auto tested and
> > reported, somehow in this way. You just create a temporary branch
> 
> Sorry, no.

That's fine. Then how about including some text "fix build errors" or
"fix build warnings" or paste the original gcc error/warning messages,
somewhere in the changelog or subject?

That will also allow me recognize that it's a build fix commit and to
make it unconditionally report back any build results.

Thanks,
Fengguang

Re: [PATCH] inet: Initialize per-netns inetpeer roots in net/ipv{4,6}/route.c

[Fengguang Wu]

On Sun, Jun 10, 2012 at 12:43:39PM +0800, Fengguang Wu wrote:
> On Sat, Jun 09, 2012 at 09:21:47PM -0700, David Miller wrote:
> > From: Fengguang Wu <wfg@linux.intel.com>
> > Date: Sun, 10 Jun 2012 11:16:34 +0800
> > 
> > > In long run, such build-fix patches can also be auto tested and
> > > reported, somehow in this way. You just create a temporary branch
> > 
> > Sorry, no.
> 
> That's fine. Then how about including some text "fix build errors" or
> "fix build warnings" or paste the original gcc error/warning messages,
> somewhere in the changelog or subject?
> 
> That will also allow me recognize that it's a build fix commit and to
> make it unconditionally report back any build results.

Or better, simply include a 

        Reported-by: Fengguang Wu <wfg@linux.intel.com>

line in the commit. Then I can reliably detect that it actually tries
to fix some build error/waring reported by me, and verbosely report
back whether the commit actually fix things up.

Thanks,
Fengguang

Re: [PATCH] inet: Initialize per-netns inetpeer roots in net/ipv{4,6}/route.c

[David Miller]

From: Fengguang Wu <wfg@linux.intel.com>
Date: Sun, 10 Jun 2012 12:43:39 +0800

> That will also allow me recognize that it's a build fix commit and to
> make it unconditionally report back any build results.

How many extra tasks do you want me to add to my already backlogged
workflow?

I'm not doing extra work for you, sorry.

Re: [PATCH] inet: Initialize per-netns inetpeer roots in net/ipv{4,6}/route.c

[David Miller]

From: Fengguang Wu <wfg@linux.intel.com>
Date: Sun, 10 Jun 2012 12:49:34 +0800

> On Sun, Jun 10, 2012 at 12:43:39PM +0800, Fengguang Wu wrote:
>> On Sat, Jun 09, 2012 at 09:21:47PM -0700, David Miller wrote:
>> > From: Fengguang Wu <wfg@linux.intel.com>
>> > Date: Sun, 10 Jun 2012 11:16:34 +0800
>> > 
>> > > In long run, such build-fix patches can also be auto tested and
>> > > reported, somehow in this way. You just create a temporary branch
>> > 
>> > Sorry, no.
>> 
>> That's fine. Then how about including some text "fix build errors" or
>> "fix build warnings" or paste the original gcc error/warning messages,
>> somewhere in the changelog or subject?
>> 
>> That will also allow me recognize that it's a build fix commit and to
>> make it unconditionally report back any build results.
> 
> Or better, simply include a 
> 
>         Reported-by: Fengguang Wu <wfg@linux.intel.com>

Now that on the other hand I should have done and was an oversight.

But all the other crap, is absolutely unreasonable of you to ask of me.

Re: [PATCH] inet: Initialize per-netns inetpeer roots in net/ipv{4,6}/route.c

[Fengguang Wu]

On Sat, Jun 09, 2012 at 10:04:21PM -0700, David Miller wrote:
> From: Fengguang Wu <wfg@linux.intel.com>
> Date: Sun, 10 Jun 2012 12:49:34 +0800
> 
> > On Sun, Jun 10, 2012 at 12:43:39PM +0800, Fengguang Wu wrote:
> >> On Sat, Jun 09, 2012 at 09:21:47PM -0700, David Miller wrote:
> >> > From: Fengguang Wu <wfg@linux.intel.com>
> >> > Date: Sun, 10 Jun 2012 11:16:34 +0800
> >> > 
> >> > > In long run, such build-fix patches can also be auto tested and
> >> > > reported, somehow in this way. You just create a temporary branch
> >> > 
> >> > Sorry, no.
> >> 
> >> That's fine. Then how about including some text "fix build errors" or
> >> "fix build warnings" or paste the original gcc error/warning messages,
> >> somewhere in the changelog or subject?
> >> 
> >> That will also allow me recognize that it's a build fix commit and to
> >> make it unconditionally report back any build results.
> > 
> > Or better, simply include a 
> > 
> >         Reported-by: Fengguang Wu <wfg@linux.intel.com>
> 
> Now that on the other hand I should have done and was an oversight.

That's fine.

Please feel free to add that "Reported-by" to get verbose build report,
as well as to _NOT_ add the above line to avoid receiving reports when
the fix is obviously correct.

Ie. use the tag as a way to control my script.

> But all the other crap, is absolutely unreasonable of you to ask of me.

Yup.. Thanks for your time!

Regards,
Fengguang