From: Dave Jones <davej@redhat.com>
To: Marc Dionne <marc.c.dionne@gmail.com>
Cc: Francois Romieu <romieu@fr.zoreil.com>,
Thomas Gleixner <tglx@linutronix.de>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: NOHZ: local_softirq_pending 08
Date: Sun, 10 Jun 2012 16:40:16 -0400 [thread overview]
Message-ID: <20120610204015.GA10066@redhat.com> (raw)
In-Reply-To: <CAB9dFdvXz85hc0p_Yanir4N6jJf9Q26crgU6a1r8VjWh8LXeHg@mail.gmail.com>
On Fri, Jun 08, 2012 at 06:33:09PM -0400, Marc Dionne wrote:
> On Fri, Jun 8, 2012 at 5:53 PM, Francois Romieu <romieu@fr.zoreil.com> wrote:
> > index 4a05b68..d452441 100644
> > --- a/drivers/net/ethernet/realtek/r8169.c
> > +++ b/drivers/net/ethernet/realtek/r8169.c
> > @@ -5934,11 +5934,7 @@ static void rtl_slow_event_work(struct rtl8169_private *tp)
> > if (status & LinkChg)
> > __rtl8169_check_link_status(dev, tp, tp->mmio_addr, true);
> >
> > - napi_disable(&tp->napi);
> > - rtl_irq_disable(tp);
> > -
> > - napi_enable(&tp->napi);
> > - napi_schedule(&tp->napi);
> > + rtl_irq_enable_all(tp);
> > }
> >
> > static void rtl_task(struct work_struct *work)
>
> That works for me - no warnings after several reboots and bringing the
> interface up/down many times.
Yep, looks good to me too. Thanks Francois
Dave
next prev parent reply other threads:[~2012-06-10 20:40 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 21:48 NOHZ: local_softirq_pending 08 Dave Jones
2012-05-31 7:52 ` Thomas Gleixner
2012-05-31 7:56 ` Eric Dumazet
2012-05-31 14:04 ` Dave Jones
2012-06-08 16:46 ` Nikos Chantziaras
2012-06-01 22:57 ` Francois Romieu
2012-06-02 20:58 ` Marc Dionne
2012-06-05 23:15 ` Francois Romieu
2012-06-06 1:46 ` Dave Jones
2012-06-06 5:42 ` Francois Romieu
2012-06-08 2:34 ` Dave Jones
2012-06-08 7:57 ` Thomas Gleixner
2012-06-08 14:23 ` Dave Jones
2012-06-08 14:51 ` Thomas Gleixner
2012-06-08 20:27 ` Francois Romieu
2012-06-08 20:41 ` Thomas Gleixner
2012-06-08 21:53 ` Francois Romieu
2012-06-08 22:33 ` Marc Dionne
2012-06-10 20:40 ` Dave Jones [this message]
2012-06-25 12:38 ` Johannes Stezenbach
2012-06-25 19:28 ` Francois Romieu
2012-06-25 19:52 ` Dave Jones
2012-06-08 8:32 ` Johannes Stezenbach
-- strict thread matches above, loose matches on Subject: below --
2009-10-11 9:52 Dave Young
2009-10-11 10:08 ` Johannes Berg
2009-10-11 10:17 ` Michael Buesch
2009-10-11 10:37 ` Johannes Berg
2009-10-11 10:38 ` David Miller
2009-10-11 10:55 ` Dave Young
2009-10-11 11:18 ` Tilman Schmidt
2009-10-11 11:40 ` Johannes Berg
2009-10-12 8:28 ` Tilman Schmidt
2009-10-12 10:32 ` David Miller
2009-10-12 11:25 ` Tilman Schmidt
2009-10-15 11:40 ` Jarek Poplawski
2009-10-15 17:53 ` Jarek Poplawski
2009-10-21 18:46 ` Tilman Schmidt
2009-10-22 23:37 ` Tilman Schmidt
2009-10-23 13:34 ` Johannes Berg
2009-10-23 14:27 ` Tilman Schmidt
2009-10-23 14:31 ` Johannes Berg
2009-10-23 16:33 ` Tilman Schmidt
2009-10-11 16:39 ` Joe Korty
2007-05-29 6:01 Rafał Bilski
2007-05-28 21:04 Rafał Bilski
2007-05-28 22:12 ` Anant Nitya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120610204015.GA10066@redhat.com \
--to=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.c.dionne@gmail.com \
--cc=romieu@fr.zoreil.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox