From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Yadwinder Singh Brar <yadi.brar01@gmail.com>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lrg@ti.com>,
Yadwinder Singh Brar <yadi.brar@samsung.com>
Subject: Re: [PATCH v2 2/2] regulator: Parse ramp_delay in while parsing DT for regulators.
Date: Mon, 11 Jun 2012 12:07:54 +0800 [thread overview]
Message-ID: <20120611040752.GI4218@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1339240239-5626-2-git-send-email-yadi.brar@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 535 bytes --]
On Sat, Jun 09, 2012 at 04:40:39PM +0530, Yadwinder Singh Brar wrote:
> For some hardwares ramp_delay for BUCKs is a configurable parameter which can
> be configured through DT.This patch adds support for parsing ramp_delay also
> while parsing DT for regulators.
I think this is a sensible idea but I think that we should go further,
move the value into the constraints and add set and get operations too
so that all the device needs to do is provide the operations (ideally
just the translation functions for regmap using devices).
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-06-11 4:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-09 11:10 [PATCH v2 1/2] regulator: core: Add regulator_set_voltage_time_sel to calculate ramp delay Yadwinder Singh Brar
2012-06-09 11:10 ` [PATCH v2 2/2] regulator: Parse ramp_delay in while parsing DT for regulators Yadwinder Singh Brar
2012-06-11 4:07 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120611040752.GI4218@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=yadi.brar01@gmail.com \
--cc=yadi.brar@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox