From: Ingo Molnar <mingo@kernel.org>
To: Alexander Gordeev <agordeev@redhat.com>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
Yinghai Lu <yinghai@kernel.org>
Subject: Re: [PATCH] x86/apic: Eliminate cpu_mask_to_apicid() operation
Date: Mon, 11 Jun 2012 10:22:49 +0200 [thread overview]
Message-ID: <20120611082249.GC31556@gmail.com> (raw)
In-Reply-To: <20120608165330.GE4777@dhcp-26-207.brq.redhat.com>
* Alexander Gordeev <agordeev@redhat.com> wrote:
> @@ -2151,7 +2134,12 @@ int default_cpu_mask_to_apicid_and(const struct cpumask *cpumask,
> break;
> }
>
> - return __default_cpu_to_apicid(cpu, apicid);
> + if (likely((unsigned int)cpu < nr_cpu_ids)) {
> + *apicid = per_cpu(x86_cpu_to_apicid, cpu);
> + return 0;
> + } else {
> + return -EINVAL;
> + }
The type cast is rather ugly - why not change the cpu type to
unsigned int?
Also, the else block is superfluous, just make it a return
-EINVAL?
Thanks,
Ingo
next prev parent reply other threads:[~2012-06-11 8:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-05 11:23 [PATCH 4/8] x86: apic: Factor out default vector_allocation_domain() operations Alexander Gordeev
2012-06-06 8:22 ` Ingo Molnar
2012-06-06 8:42 ` Alexander Gordeev
2012-06-07 13:14 ` [PATCH 4/8] x86/apic: Factor out default vector_allocation_domain() operation Alexander Gordeev
2012-06-07 22:24 ` Suresh Siddha
2012-06-08 14:49 ` [tip:x86/apic] " tip-bot for Alexander Gordeev
2012-06-07 13:15 ` [PATCH 5/8] x86/apic: Try to spread IRQ vectors to different priority levels Alexander Gordeev
2012-06-07 22:26 ` Suresh Siddha
2012-06-08 14:50 ` [tip:x86/apic] " tip-bot for Alexander Gordeev
2012-06-20 17:23 ` H. Peter Anvin
2012-06-20 21:41 ` Suresh Siddha
2012-06-20 21:46 ` H. Peter Anvin
2012-06-07 13:15 ` [PATCH 6/8] x86/apic: Avoid useless scanning thru a cpumask in assign_irq_vector() Alexander Gordeev
2012-06-07 22:28 ` Suresh Siddha
2012-06-08 14:51 ` [tip:x86/apic] " tip-bot for Alexander Gordeev
2012-06-07 13:15 ` [PATCH 7/8] x86/apic: Make cpu_mask_to_apicid() operations return error code Alexander Gordeev
2012-06-07 22:24 ` Suresh Siddha
2012-06-08 15:15 ` Alexander Gordeev
2012-06-08 16:53 ` [PATCH] x86/apic: Eliminate cpu_mask_to_apicid() operation Alexander Gordeev
2012-06-08 18:24 ` Suresh Siddha
2012-06-08 22:36 ` Yinghai Lu
2012-06-11 8:22 ` Ingo Molnar [this message]
2012-06-11 10:51 ` Alexander Gordeev
2012-06-08 14:51 ` [tip:x86/apic] x86/apic: Make cpu_mask_to_apicid() operations return error code tip-bot for Alexander Gordeev
2012-06-07 13:16 ` [PATCH 8/8] x86/apic: Make cpu_mask_to_apicid() operations check cpu_online_mask Alexander Gordeev
2012-06-08 14:52 ` [tip:x86/apic] " tip-bot for Alexander Gordeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120611082249.GC31556@gmail.com \
--to=mingo@kernel.org \
--cc=agordeev@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).