From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jonghwa Lee <jonghwa3.lee@samsung.com>
Cc: linux-kernel@vger.kernel.org,
Mike Turquette <mturquette@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
Hartley Sweeten <hsweeten@visionengravers.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH v3] clock: max77686: Add driver for Maxim 77686 32KHz crystal oscillator
Date: Mon, 11 Jun 2012 19:16:25 +0800 [thread overview]
Message-ID: <20120611111624.GJ11439@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1339412480-7558-1-git-send-email-jonghwa3.lee@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 396 bytes --]
On Mon, Jun 11, 2012 at 08:01:20PM +0900, Jonghwa Lee wrote:
> v3
> - Add mutex to the max77686_clk structure to make atomic execution of enable/disable function.
No, you've not understood the issue. As I said on my previous review
these need to be prepare() and unprepare() since enable() and disable()
execute in atomic context - that means you can't do I2C I/O and you
can't take mutexes.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-06-11 11:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 11:01 [PATCH v3] clock: max77686: Add driver for Maxim 77686 32KHz crystal oscillator Jonghwa Lee
2012-06-11 11:09 ` Felipe Balbi
2012-06-11 11:21 ` Mark Brown
2012-06-11 11:16 ` Mark Brown [this message]
2012-06-11 15:25 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120611111624.GJ11439@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=arnd@arndb.de \
--cc=hsweeten@visionengravers.com \
--cc=jonghwa3.lee@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox