Re: [PATCH v2] watchdog: Quiet down the boot messages

[Don Zickus <dzickus@redhat.com>]

On Fri, Jun 08, 2012 at 02:39:28PM -0700, Andrew Morton wrote:
> > After the change, it is simplified to:
> > 
> >     ..TIMER: vector=0x30 apic1=0 pin1=2 apic2=-1 pin2=-1
> >     CPU0: Intel(R) Core(TM)2 Quad CPU    Q9550  @ 2.83GHz stepping 0a
> >     Performance Events: PEBS fmt0+, Core2 events, Intel PMU driver.
> >     ... version:                2
> >     ... bit width:              40
> >     ... generic registers:      2
> >     ... value mask:             000000ffffffffff
> >     ... max period:             000000007fffffff
> >     ... fixed-purpose events:   3
> >     ... event mask:             0000000700000003
> >     NMI watchdog enabled, takes one hw-pmu counter.
> >     Booting Node   0, Processors  #1 #2 #3 Ok.
> >     Brought up 4 CPUs
> 
> What is the behaviour of this change at suspend/resume time?

Good question.  Aside from the brokeness that cpu0 doesn't seem to restart
after cpu suspend/resume (hence a previous patch in this space), the printks
disappear during resume.

Now with the cpu0 fix patch, the message will reappear and state that the
watchdog is enabled for all cpus.  But with just this patch, that message
will not show up during resume.

> 
> > +		if (cpu ==0 || cpu0_err)
> 
> Please use checkpatch.  It's free!

Heh.  Sorry about that.

Cheers,
Don