Re: [PATCH v2] lib/decompress_unxz.c: removing all memory helper functions

H. Peter Anvin
2012-06-12T17:49:18Z

On 06/12/2012 10:44 AM, Nicolas Pitre wrote:
> On Tue, 12 Jun 2012, H. Peter Anvin wrote:
>
>> On 06/12/2012 10:26 AM, Nicolas Pitre wrote:
>>>
>>> Instead of copying, maybe this would be much better to make the content
>>> of lib/string.c usable in a pre-boot environment.
>>>
>>
>> Not sure about that... a lot of it is #ifndef __HAVE_ARCH_* and you
>> *really* want those optimizations on some arches.
>
> Sure. What about:
>
> lib/boot/mem.c: lib/string.c
> sed 's/^#ifndef __HAVE_ARCH_/#ifndef __HAVE_PREBOOT_ARCH_/' < $< > $@
>
> This is over simplified but you get the idea. Maybe lib/string.c itself
> should be split into several files to help with a finer grained
> selection.
>

The point is that I think we pretty much end up with a null usable set
in the end.

-hpa