From: Dong Aisheng <aisheng.dong@freescale.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Devendra Naga <devendra.aaru@gmail.com>,
Dong Aisheng <B29396@freescale.com>,
Shawn Guo <shawn.guo@linaro.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] pinctrl: pinctrl-mxs: Take care of frees if the kzalloc fails
Date: Tue, 12 Jun 2012 19:50:34 +0800 [thread overview]
Message-ID: <20120612115033.GG25534@shlinux2.ap.freescale.net> (raw)
In-Reply-To: <CACRpkdb+GwB_VxfmPSwfc-1BfCs+fePSqnN3binY0xttb5p7xA@mail.gmail.com>
On Tue, Jun 12, 2012 at 01:31:25PM +0200, Linus Walleij wrote:
> On Sat, Jun 9, 2012 at 2:01 PM, Devendra Naga <devendra.aaru@gmail.com> wrote:
>
> > if there is no purecfg , the group pointer is allocated using kzalloc and if it
> > fails to allocate, we wont free the new_map,
> >
> > if config is true, we call kmemdup and if it
> > fails to do so we wont free the allocated group if there is no purecfg.
> >
> > fix this by doing the frees of new_map pointer and group pointers.
> >
> > Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
>
> Obviously correct so applied.
>
> Dong, Shawn: any ACKs?
>
Acked-by: Dong Aisheng <dong.aisheng@linaro.org>
Regards
Dong Aisheng
prev parent reply other threads:[~2012-06-12 11:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-09 12:01 [PATCH 1/2] pinctrl: pinctrl-mxs: Take care of frees if the kzalloc fails Devendra Naga
2012-06-12 11:31 ` Linus Walleij
2012-06-12 11:50 ` Dong Aisheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120612115033.GG25534@shlinux2.ap.freescale.net \
--to=aisheng.dong@freescale.com \
--cc=B29396@freescale.com \
--cc=devendra.aaru@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox