From: Wanpeng Li <liwp.linux@gmail.com>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: linux-kernel@vger.kernel.org,
Gavin Shan <shangw@linux.vnet.ibm.com>,
Wanpeng Li <liwp.linux@gmail.com>
Subject: Re: [PATCH v2] writeback: avoid race when update bandwidth
Date: Tue, 12 Jun 2012 19:58:21 +0800 [thread overview]
Message-ID: <20120612115746.GA3980@kernel> (raw)
In-Reply-To: <20120612115219.GA17348@localhost>
On Tue, Jun 12, 2012 at 07:52:19PM +0800, Fengguang Wu wrote:
>On Tue, Jun 12, 2012 at 07:46:01PM +0800, Wanpeng Li wrote:
>> From: Wanpeng Li <liwp@linux.vnet.ibm.com>
>>
>> "V1 -> V2"
>> * remove dirty_lock
>>
>> Since bdi->wb.list_lock is used to protect the b_* lists,
>> so the flushers who call wb_writeback to writeback pages will
>> stuck when bandwidth update policy holds this lock. In order
>> to avoid this race we can introduce a new bandwidth_lock who
>> is responsible for protecting bandwidth update policy.
>>
>> Signed-off-by: Wanpeng Li <liwp.linux@gmail.com>
>
>Applied with a new title "writeback: use a standalone lock for
>updating write bandwidth". "race" is sensitive because it often
>refers to some locking error.
OK, Thanks a lot.
Regards,
Wanpeng Li
next prev parent reply other threads:[~2012-06-12 11:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 11:46 [PATCH v2] writeback: avoid race when update bandwidth Wanpeng Li
2012-06-12 11:52 ` Fengguang Wu
2012-06-12 11:58 ` Wanpeng Li [this message]
2012-06-13 3:59 ` Dave Chinner
2012-06-13 12:14 ` Fengguang Wu
2012-06-14 2:05 ` Dave Chinner
2012-06-14 14:00 ` Fengguang Wu
2012-06-15 0:06 ` Dave Chinner
2012-06-15 0:29 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120612115746.GA3980@kernel \
--to=liwp.linux@gmail.com \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shangw@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox