From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: Al Viro <viro@ZenIV.linux.org.uk>, Alex Elder <elder@kernel.org>,
linux-fsdevel@suse.cz, LKML <linux-kernel@vger.kernel.org>,
xfs@oss.sgi.com, Ben Myers <bpm@sgi.com>
Subject: Re: [PATCH 18/27] xfs: Convert to new freezing code
Date: Tue, 12 Jun 2012 10:23:47 -0400 [thread overview]
Message-ID: <20120612142346.GA25132@infradead.org> (raw)
In-Reply-To: <1339510848-16992-19-git-send-email-jack@suse.cz>
> + * We will pass freeze protection with a transaction. So tell lockdep
> + * we released it.
> + */
> + rwsem_release(&ioend->io_inode->i_sb->s_writers.lock_map[SB_FREEZE_FS-1],
> + 1, _THIS_IP_);
I'll need some time to get through the whole series, but repeated use
of constructs like this really screams for a helper abstracting it out
and documenting it.
next prev parent reply other threads:[~2012-06-12 14:23 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 14:20 [PATCH 00/27 v7] Fix filesystem freezing deadlocks Jan Kara
2012-06-12 14:20 ` [PATCH 01/27] fb_defio: Push file_update_time() into fb_deferred_io_mkwrite() Jan Kara
2012-06-12 14:20 ` [PATCH 02/27] fs: Push file_update_time() into __block_page_mkwrite() Jan Kara
2012-06-12 14:20 ` [PATCH 03/27] ceph: Push file_update_time() into ceph_page_mkwrite() Jan Kara
2012-06-12 14:20 ` [PATCH 04/27] 9p: Push file_update_time() into v9fs_vm_page_mkwrite() Jan Kara
2012-06-12 14:20 ` [PATCH 05/27] gfs2: Push file_update_time() into gfs2_page_mkwrite() Jan Kara
2012-06-12 14:20 ` [PATCH 06/27] sysfs: Push file_update_time() into bin_page_mkwrite() Jan Kara
2012-06-12 14:20 ` [PATCH 07/27] mm: Update file times from fault path only if .page_mkwrite is not set Jan Kara
2012-06-12 14:20 ` [PATCH 08/27] mm: Make default vm_ops provide ->page_mkwrite handler Jan Kara
2012-06-12 14:20 ` [PATCH 09/27] fs: Push mnt_want_write() outside of i_mutex Jan Kara
2012-06-12 14:20 ` [PATCH 10/27] fat: " Jan Kara
2012-06-12 14:20 ` [PATCH 11/27] btrfs: " Jan Kara
2012-06-12 14:20 ` [PATCH 12/27] nfsd: " Jan Kara
2012-06-12 17:25 ` J. Bruce Fields
2012-06-12 14:20 ` [PATCH 13/27] fs: Improve filesystem freezing handling Jan Kara
2012-06-12 14:20 ` [PATCH 14/27] fs: Add freezing handling to mnt_want_write() / mnt_drop_write() Jan Kara
2012-06-12 14:20 ` [PATCH 15/27] fs: Skip atime update on frozen filesystem Jan Kara
2012-06-12 14:20 ` [PATCH 16/27] fs: Protect write paths by sb_start_write - sb_end_write Jan Kara
2012-06-12 14:20 ` [PATCH 17/27] ext4: Convert to new freezing mechanism Jan Kara
2012-06-12 14:20 ` [PATCH 18/27] xfs: Convert to new freezing code Jan Kara
2012-06-12 14:23 ` Christoph Hellwig [this message]
2012-06-12 14:32 ` Jan Kara
2012-06-12 14:20 ` [PATCH 19/27] ocfs2: Convert to new freezing mechanism Jan Kara
2012-06-12 14:20 ` [PATCH 20/27] gfs2: " Jan Kara
2012-06-12 14:20 ` [PATCH 21/27] fuse: " Jan Kara
2012-06-12 14:20 ` [PATCH 22/27] ntfs: " Jan Kara
2012-06-12 14:20 ` [PATCH 23/27] nilfs2: " Jan Kara
2012-06-12 14:20 ` [PATCH 24/27] btrfs: " Jan Kara
2012-06-12 14:20 ` [PATCH 25/27] ext2: Implement freezing Jan Kara
2012-06-12 14:20 ` [PATCH 26/27] fs: Remove old freezing mechanism Jan Kara
2012-06-12 14:20 ` [PATCH 27/27] Documentation: Correct s_umount state for freeze_fs/unfreeze_fs Jan Kara
-- strict thread matches above, loose matches on Subject: below --
2012-04-16 16:13 [PATCH 00/19 v5] Fix filesystem freezing deadlocks Jan Kara
2012-04-16 16:13 ` [PATCH 18/27] xfs: Convert to new freezing code Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120612142346.GA25132@infradead.org \
--to=hch@infradead.org \
--cc=bpm@sgi.com \
--cc=elder@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox