From: Greg KH <gregkh@linuxfoundation.org>
To: "Javier Muñoz" <jmunhoz@igalia.com>
Cc: teddy.wang@siliconmotion.com.cn, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] staging: sm7xxfb: sm7xx becomes sm7xxfb
Date: Tue, 12 Jun 2012 10:55:06 -0700 [thread overview]
Message-ID: <20120612175506.GA27756@kroah.com> (raw)
In-Reply-To: <4FD4843F.6070602@igalia.com>
On Sun, Jun 10, 2012 at 01:25:51PM +0200, Javier Muñoz wrote:
> On 06/10/2012 01:12 PM, Javier M. Mellid wrote:
> > From: "Javier M. Mellid" <jmunhoz@igalia.com>
> >
> > Rename sm7xx driver to sm7xxfb. Fix Kconfig and Makefile to fit the new
> > change.
> >
> > Changes are coherent with the rest of stable framebuffer drivers. TODO
> > updated.
>
> Just one doubt. I am using 'git mv' here and it works Ok. 'git log
> --follow' would be the way to see the whole history after this commit.
> Should I follow another approach? I am using a 'similar approach' to
> ed16648eb5b86917f0b90bdcdbc857202da72f90 commit to rename.
>
> Please, let me know if I should redo this patch.
When I apply it, git will detect the file being moved.
Also, patch, and git, now support renames when generating patches, you
should use that and it will be a bit more obvious that this really is
just a rename.
thanks,
greg k-h
prev parent reply other threads:[~2012-06-12 17:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-10 11:12 [PATCH 0/3] staging: sm7xx: code improvements and cleanup Javier M. Mellid
2012-06-10 11:12 ` [PATCH 1/3] staging: sm7xx: code improvement Javier M. Mellid
2012-06-10 11:12 ` [PATCH 2/3] staging: sm7xx: update comments and clarify supported chips Javier M. Mellid
2012-06-10 11:12 ` [PATCH 3/3] staging: sm7xxfb: sm7xx becomes sm7xxfb Javier M. Mellid
2012-06-10 11:25 ` Javier Muñoz
2012-06-12 17:55 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120612175506.GA27756@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=jmunhoz@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=teddy.wang@siliconmotion.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox