From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ben Chan <benchan@chromium.org>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Sage Ahn <syahn@gctsemi.com>
Subject: Re: [PATCH v2] staging: gdm72xx: Fix spinlock recursion on gdm_usb_send_complete
Date: Tue, 12 Jun 2012 11:07:09 -0700 [thread overview]
Message-ID: <20120612180709.GA9775@kroah.com> (raw)
In-Reply-To: <1339522852-28066-1-git-send-email-benchan@chromium.org>
On Tue, Jun 12, 2012 at 10:40:52AM -0700, Ben Chan wrote:
> This patch fixes a spinlock recursion bug on several call sites of
> gdm_usb_send_complete by not calling spin_lock_irqsave on
> urb->context->tx_cxt->lock when the lock has already been acquired.
>
> Signed-off-by: Ben Chan <benchan@chromium.org>
> Cc: Sage Ahn <syahn@gctsemi.com>
> ---
> This revised patch simplifies the previous patch.
Argh, I _just_ applied the previous patch :(
Care to send me an incremental one, fixing it up to look like this now
so I don't have to revert your previous one?
thanks,
greg k-h
prev parent reply other threads:[~2012-06-12 18:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 17:40 [PATCH v2] staging: gdm72xx: Fix spinlock recursion on gdm_usb_send_complete Ben Chan
2012-06-12 18:07 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120612180709.GA9775@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=benchan@chromium.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syahn@gctsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox