From: Dan Carpenter <dan.carpenter@oracle.com>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
devel@driverdev.osuosl.org, fmhess@users.sourceforge.net,
abbotti@mev.co.uk, gregkh@linuxfoundation.org
Subject: Re: [PATCH 8/8] staging: comedi: cleanup comedi_alloc_subdevices
Date: Tue, 12 Jun 2012 22:49:40 +0300 [thread overview]
Message-ID: <20120612194940.GZ4400@mwanda> (raw)
In-Reply-To: <201206121159.55522.hartleys@visionengravers.com>
On Tue, Jun 12, 2012 at 11:59:55AM -0700, H Hartley Sweeten wrote:
> for (i = 0; i < num_subdevices; ++i) {
> - dev->subdevices[i].device = dev;
> - dev->subdevices[i].async_dma_dir = DMA_NONE;
> - spin_lock_init(&dev->subdevices[i].spin_lock);
> - dev->subdevices[i].minor = -1;
> + s = dev->subdevices + i;
You don't have to resend, but I think this would look better as:
s = &dev->subdevices[i];
> + s->device = dev;
> + s->async_dma_dir = DMA_NONE;
> + spin_lock_init(&s->spin_lock);
> + s->minor = -1;
> }
Btw, this patchset is great. Nice.
regards,
dan carpenter
next prev parent reply other threads:[~2012-06-12 19:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 18:59 [PATCH 8/8] staging: comedi: cleanup comedi_alloc_subdevices H Hartley Sweeten
2012-06-12 19:49 ` Dan Carpenter [this message]
2012-06-12 20:20 ` H Hartley Sweeten
2012-06-13 6:23 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120612194940.GZ4400@mwanda \
--to=dan.carpenter@oracle.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=fmhess@users.sourceforge.net \
--cc=gregkh@linuxfoundation.org \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox