public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
	devel@driverdev.osuosl.org, abbotti@mev.co.uk,
	fmhess@users.sourceforge.net
Subject: Re: [PATCH 2/8] staging: comedi: change type of num_subdevices parameter to comedi_alloc_subdevices
Date: Tue, 12 Jun 2012 14:40:25 -0700	[thread overview]
Message-ID: <20120612214025.GA4323@kroah.com> (raw)
In-Reply-To: <201206121157.27498.hartleys@visionengravers.com>

On Tue, Jun 12, 2012 at 11:57:27AM -0700, H Hartley Sweeten wrote:
> From 606739d47df00ac9767e3256ab8f6eb1572bd429 Mon Sep 17 00:00:00 2001
> From: H Hartley Sweeten <hsweeten@visionengravers.com>
> Date: Tue, 12 Jun 2012 09:45:17 -0700
> Subject: [PATCH 2/8] staging: comedi: change type of num_subdevices parameter
>  to comedi_alloc_subdevices
> 
> The n_subdevices variable of struct comedi_device is an int type.
> Change the type of the comedi_alloc_subdevices 'num_subdevices' from
> an unsigned int to an int to match it.

Ok, some hints on how to send emails, don't do it this way :)

You need to use git send-email, which will not duplicate the From and
stuff in the body of the email.

Otherwise, I have to edit the patches by hand, or that information ends
up in the commit log for the patch:

-----------
commit c70c98a0180522411aff8eb87e10523eef2fe3f6
Author: H Hartley Sweeten <hartleys@visionengravers.com>
Date:   Tue Jun 12 11:57:27 2012 -0700

    staging: comedi: change type of num_subdevices parameter to comedi_alloc_subdevices
    
    From 606739d47df00ac9767e3256ab8f6eb1572bd429 Mon Sep 17 00:00:00 2001
    From: H Hartley Sweeten <hsweeten@visionengravers.com>
    Date: Tue, 12 Jun 2012 09:45:17 -0700
    Subject: [PATCH 2/8] staging: comedi: change type of num_subdevices parameter
     to comedi_alloc_subdevices
    
    The n_subdevices variable of struct comedi_device is an int type.
    Change the type of the comedi_alloc_subdevices 'num_subdevices' from
    an unsigned int to an int to match it.
    
    Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
    Cc: Ian Abbott <abbott@mev.co.uk>
    Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

-------------

I'll edit up these 8, but in the future, please don't do that.

thanks,

greg k-h

      reply	other threads:[~2012-06-12 21:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-12 18:57 [PATCH 2/8] staging: comedi: change type of num_subdevices parameter to comedi_alloc_subdevices H Hartley Sweeten
2012-06-12 21:40 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120612214025.GA4323@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=fmhess@users.sourceforge.net \
    --cc=hartleys@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox