From: Greg KH <gregkh@linuxfoundation.org>
To: Jiri Slaby <jslaby@suse.cz>
Cc: alan@linux.intel.com, linux-kernel@vger.kernel.org, jirislaby@gmail.com
Subject: Re: [PATCH 16/24] PTY: add tty_port
Date: Tue, 12 Jun 2012 15:55:44 -0700 [thread overview]
Message-ID: <20120612225544.GA13297@kroah.com> (raw)
In-Reply-To: <1338809738-18967-17-git-send-email-jslaby@suse.cz>
On Mon, Jun 04, 2012 at 01:35:30PM +0200, Jiri Slaby wrote:
> This has *no* function in the PTY driver yet. However as the tty
> buffers will move to the tty_port structure, we will need tty_port for
> all TTYs in the system, PTY inclusive.
>
> For PTYs this is ensured by allocating 2 tty_port's in pty_install,
> i.e. where the tty->link is allocated. Both tty_port's are properly
> assigned to each end of the tty.
>
> Freeing is done at the same place where tty is freed, i.e. in
> tty->ops->cleanup.
>
> This means BTW that tty_port does not outlive TTY in PTY. This might
> be a subject to change in the future if we see some problems.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> ---
> drivers/tty/pty.c | 25 +++++++++++++++++++++----
> 1 file changed, 21 insertions(+), 4 deletions(-)
As the locking rework got removed from Linus's tree, this patch doesn't
apply, so I've stopped at this point in the series.
Care to refresh it, and resend the rest of the patches, if you still
want me to apply them (I recall 24 wasn't ok, right?)
thanks,
greg k-h
next prev parent reply other threads:[~2012-06-12 22:55 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 11:35 [PATCH 00/25] TTY buffer in tty_port -- prep no. 3 Jiri Slaby
2012-06-04 11:35 ` [PATCH 01/24] TTY: cyclades, add local pointer for card Jiri Slaby
2012-06-04 11:35 ` [PATCH 02/24] TTY: ircomm, add tty_port Jiri Slaby
2012-06-04 11:35 ` [PATCH 03/24] TTY: ircomm, use close times from tty_port Jiri Slaby
2012-06-04 11:35 ` [PATCH 04/24] TTY: ircomm, use open counts " Jiri Slaby
2012-06-04 16:36 ` Alan Cox
2012-06-04 11:35 ` [PATCH 05/24] TTY: ircomm, use flags " Jiri Slaby
2012-06-04 11:35 ` [PATCH 06/24] TTY: ircomm, revamp locking Jiri Slaby
2012-06-04 16:57 ` Alan Cox
2012-06-04 11:35 ` [PATCH 07/24] TTY: ircomm, use tty from tty_port Jiri Slaby
2012-06-04 11:35 ` [PATCH 08/24] TTY: ircomm, define local tty_port Jiri Slaby
2012-06-04 11:35 ` [PATCH 09/24] TTY: ircomm, define carrier routines Jiri Slaby
2012-06-04 11:35 ` [PATCH 10/24] TTY: ircomm, use tty_port_close_end helper Jiri Slaby
2012-06-04 11:35 ` [PATCH 11/24] TTY: ircomm, use tty_port_close_start helper Jiri Slaby
2012-06-04 11:35 ` [PATCH 12/24] TTY: um/line, add tty_port Jiri Slaby
2012-06-04 11:35 ` [PATCH 13/24] TTY: um/line, use tty from tty_port Jiri Slaby
2012-06-04 12:01 ` Richard Weinberger
2012-06-04 15:20 ` Jiri Slaby
2012-06-04 15:29 ` Richard Weinberger
2012-06-04 15:41 ` Jiri Slaby
2012-06-04 15:42 ` Richard Weinberger
2012-06-04 16:27 ` [uml-devel] " Boaz Harrosh
2012-06-04 16:29 ` Richard Weinberger
2012-06-04 16:37 ` Boaz Harrosh
2012-06-04 16:55 ` Boaz Harrosh
2012-06-04 17:05 ` Richard Weinberger
2012-06-04 17:14 ` Boaz Harrosh
2012-06-04 15:58 ` Alan Cox
2012-06-04 11:35 ` [PATCH 14/24] PTY: remove one empty ops->remove Jiri Slaby
2012-06-04 11:35 ` [PATCH 15/24] PTY: merge pty_install implementations Jiri Slaby
2012-06-04 11:35 ` [PATCH 16/24] PTY: add tty_port Jiri Slaby
2012-06-12 22:55 ` Greg KH [this message]
2012-06-14 0:29 ` Greg KH
2012-06-14 0:31 ` Greg KH
2012-06-04 11:35 ` [PATCH 17/24] TTY: vt, remove con_schedule_flip Jiri Slaby
2012-06-04 11:35 ` [PATCH 18/24] TTY: provide drivers with tty_port_install Jiri Slaby
2012-06-04 11:35 ` [PATCH 19/24] TTY: vt, add ->install Jiri Slaby
2012-06-04 11:35 ` [PATCH 20/24] TTY: usb-serial, use tty_port_install Jiri Slaby
2012-06-04 11:35 ` [PATCH 21/24] TTY: centralize fail paths in tty_register_driver Jiri Slaby
2012-06-04 11:35 ` [PATCH 22/24] TTY: add ports array to tty_driver Jiri Slaby
2012-06-04 11:35 ` [PATCH 23/24] TTY: add tty_port_register_device helper Jiri Slaby
2012-06-04 11:35 ` [PATCH 24/24] TTY: use tty_port_register_device Jiri Slaby
2012-06-04 17:00 ` Alan Cox
2012-06-09 14:58 ` Jiri Slaby
2012-06-09 17:27 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120612225544.GA13297@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alan@linux.intel.com \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox