From: Greg KH <gregkh@linuxfoundation.org>
To: stefani@seibold.net
Cc: linux-kernel@vger.kernel.org, oneukum@suse.de, linux-usb@vger.kernel.org
Subject: Re: [PATCH 02/13] code cleanup
Date: Tue, 12 Jun 2012 18:02:09 -0700 [thread overview]
Message-ID: <20120613010209.GB6765@kroah.com> (raw)
In-Reply-To: <1339057243-10029-3-git-send-email-stefani@seibold.net>
On Thu, Jun 07, 2012 at 10:20:32AM +0200, stefani@seibold.net wrote:
> From: Stefani Seibold <stefani@seibold.net>
>
> - consistent nameing
> - more compact style
> - remove unneeded code
>
> Signed-off-by: Stefani Seibold <stefani@seibold.net>
> ---
> drivers/usb/usb-skeleton.c | 119 +++++++++++++++++---------------------------
> 1 files changed, 46 insertions(+), 73 deletions(-)
Your subject: needs to be fixed for all of these, as it does not
describe what part of the kernel is being modified.
A better example would be to use a prefix of:
Subject: [PATCH XX/13] USB: skeleton:
for all of these patches, so the shortlog entry is correct.
Care to redo this series, based on the feedback you've gotten, and
resend?
thanks,
greg k-h
next prev parent reply other threads:[~2012-06-13 1:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-07 8:20 [PATCH] fix usb skeleton driver stefani
2012-06-07 8:20 ` [PATCH 01/13] fix wrong label in skel_open stefani
2012-06-13 1:03 ` Greg KH
2012-06-07 8:20 ` [PATCH 02/13] code cleanup stefani
2012-06-07 9:06 ` Bjørn Mork
2012-06-07 9:21 ` Stefani Seibold
2012-06-07 10:49 ` Bjørn Mork
2012-06-13 1:03 ` Greg KH
2012-06-13 1:02 ` Greg KH [this message]
2012-06-13 18:00 ` Stefani Seibold
2012-06-07 8:20 ` [PATCH 03/13] remove dead code stefani
2012-06-07 15:04 ` Oliver Neukum
2012-06-07 19:40 ` Stefani Seibold
2012-06-07 8:20 ` [PATCH 04/13] remove unneeded forward declaration stefani
2012-06-07 8:20 ` [PATCH 05/13] remove pr_err() noise in skel_open stefani
2012-06-07 8:20 ` [PATCH 06/13] Handle a non blocking read without blocking stefani
2012-06-07 8:20 ` [PATCH 07/13] fix flush function stefani
2012-06-07 8:20 ` [PATCH 08/13] add fsync function stefani
2012-06-07 8:20 ` [PATCH 09/13] remove unneeded lock in skel_open stefani
2012-06-07 8:20 ` [PATCH 10/13] fix race in skel_write stefani
2012-06-07 8:20 ` [PATCH 11/13] fix kref usage in skel_open stefani
2012-06-07 8:20 ` [PATCH 12/13] Introduce single user mode stefani
2012-06-13 1:05 ` Greg KH
2012-06-07 8:20 ` [PATCH 13/13] Bump version number and add aditional author stefani
2012-06-07 9:09 ` Bjørn Mork
2012-06-13 1:00 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120613010209.GB6765@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.de \
--cc=stefani@seibold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox