From: "Michael S. Tsirkin" <mst@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: x86@kernel.org, kvm@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Avi Kivity <avi@redhat.com>,
gleb@redhat.com, Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCHv6 2/8] kvm: optimize ISR lookups
Date: Wed, 13 Jun 2012 12:26:05 +0300 [thread overview]
Message-ID: <20120613092604.GA17828@redhat.com> (raw)
In-Reply-To: <20120613090242.GA17357@redhat.com>
On Wed, Jun 13, 2012 at 12:02:42PM +0300, Michael S. Tsirkin wrote:
> > Instead of isr_cache what about a highest_isr field?
>
> >
> > When setting ISR:
> >
> > if (apic->highest_isr < me)
> > apic->highest_isr = me;
> >
> > To be invalidated on TPR updates properly.
> >
> > Its more meaningful.
>
> OK, I'll rename it highest_isr
Even better - highest_isr_cache.
Makes it explicit that it can be invalid.
--
MST
next prev parent reply other threads:[~2012-06-13 9:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-03 7:27 [PATCHv6 0/8] kvm: eoi optimization support Michael S. Tsirkin
2012-06-03 7:27 ` [PATCHv6 1/8] kvm: document lapic regs field Michael S. Tsirkin
2012-06-03 7:27 ` [PATCHv6 2/8] kvm: optimize ISR lookups Michael S. Tsirkin
2012-06-12 21:08 ` Marcelo Tosatti
2012-06-13 9:02 ` Michael S. Tsirkin
2012-06-13 9:26 ` Michael S. Tsirkin [this message]
2012-06-13 20:21 ` Marcelo Tosatti
2012-06-03 7:28 ` [PATCHv6 3/8] kvm_para: guest side for eoi avoidance Michael S. Tsirkin
2012-06-03 7:28 ` [PATCHv6 4/8] x86/bitops: note on __test_and_clear_bit atomicity Michael S. Tsirkin
2012-06-03 7:28 ` [PATCHv6 5/8] kvm: eoi msi documentation Michael S. Tsirkin
2012-06-12 22:24 ` Marcelo Tosatti
2012-06-03 7:28 ` [PATCHv6 6/8] kvm: only sync when attention bits set Michael S. Tsirkin
2012-06-12 22:27 ` Marcelo Tosatti
2012-06-13 8:19 ` Michael S. Tsirkin
2012-06-13 8:35 ` Michael S. Tsirkin
2012-06-13 20:53 ` Marcelo Tosatti
2012-06-13 21:04 ` Michael S. Tsirkin
2012-06-13 23:38 ` Marcelo Tosatti
2012-06-14 8:04 ` Michael S. Tsirkin
2012-06-03 7:28 ` [PATCHv6 7/8] kvm: rearrange injection cancelling code Michael S. Tsirkin
2012-06-03 7:28 ` [PATCHv6 8/8] kvm: host side for eoi optimization Michael S. Tsirkin
2012-06-13 21:10 ` Marcelo Tosatti
2012-06-14 8:01 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120613092604.GA17828@redhat.com \
--to=mst@redhat.com \
--cc=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mtosatti@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox