On Tue, Jun 12, 2012 at 10:23:09AM +0800, Axel Lin wrote: > Signed-off-by: Axel Lin This patch is way more invasive than it needs to be (and therefore hard to check) because > - if (dcdc->dvs_gpio && dcdc->on_vsel == vsel) > + if (dcdc->dvs_gpio && dcdc->on_vsel == selector) you've replaced vsel with selector throughout the code.