From: Andi Kleen <ak@linux.intel.com>
To: Alex Shi <alex.shi@intel.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
arnd@arndb.de, rostedt@goodmis.org, fweisbec@gmail.com,
jeremy@goop.org, seto.hidetoshi@jp.fujitsu.com,
borislav.petkov@amd.com, tony.luck@intel.com, luto@mit.edu,
riel@redhat.com, avi@redhat.com, len.brown@intel.com,
tj@kernel.org, akpm@linux-foundation.org, cl@gentwo.org,
jbeulich@suse.com, eric.dumazet@gmail.com,
akinobu.mita@gmail.com, cpw@sgi.com, penberg@kernel.org,
steiner@sgi.com, viro@zeniv.linux.org.uk,
kamezawa.hiroyu@jp.fujitsu.com, aarcange@redhat.com,
rientjes@google.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 8/8] x86/tlb: do flush_tlb_kernel_range by 'invlpg'
Date: Wed, 13 Jun 2012 07:56:56 -0700 [thread overview]
Message-ID: <20120613145656.GB32604@tassilo.jf.intel.com> (raw)
In-Reply-To: <1339492005-20241-9-git-send-email-alex.shi@intel.com>
On Tue, Jun 12, 2012 at 05:06:45PM +0800, Alex Shi wrote:
> This patch do flush_tlb_kernel_range by 'invlpg'. The performance pay
> and gain was analyzed in my patch (x86/flush_tlb: try flush_tlb_single
> one by one in flush_tlb_range). Now we move this logical into kernel
> part. The pay is multiple 'invlpg' execution cost, that is same. but
> the gain(cost reducing of TLB entries refilling) is absoulutely
> increased.
The subtle point is whether INVLPG flushes global pages or not.
After some digging I found a sentence in the SDM that says it does.
So it may be safe.
What does it improve?
-Andi
next prev parent reply other threads:[~2012-06-13 14:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 9:06 [PATCH v8 0/8] x86 TLB flush range optimizing Alex Shi
2012-06-12 9:06 ` [PATCH v8 1/8] x86/tlb_info: get last level TLB entry number of CPU Alex Shi
2012-06-12 9:06 ` [PATCH v8 2/8] x86/flush_tlb: try flush_tlb_single one by one in flush_tlb_range Alex Shi
2012-06-12 9:06 ` [PATCH v8 3/8] x86/tlb: fall back to flush all when meet a THP large page Alex Shi
2012-06-12 9:06 ` [PATCH v8 4/8] x86/tlb: add tlb_flushall_shift for specific CPU Alex Shi
2012-06-12 9:06 ` [PATCH v8 5/8] x86/tlb: add tlb_flushall_shift knob into debugfs Alex Shi
2012-06-12 9:06 ` [PATCH v8 6/8] x86/tlb: enable tlb flush range support for generic mmu and x86 Alex Shi
2012-06-12 9:06 ` [PATCH v8 7/8] x86/tlb: replace INVALIDATE_TLB_VECTOR by CALL_FUNCTION_VECTOR Alex Shi
2012-06-12 9:06 ` [PATCH v8 8/8] x86/tlb: do flush_tlb_kernel_range by 'invlpg' Alex Shi
2012-06-13 14:56 ` Andi Kleen [this message]
2012-06-14 1:10 ` Alex Shi
2012-06-14 1:26 ` Alex Shi
2012-06-14 2:10 ` Alex Shi
2012-06-21 5:25 ` Alex Shi
2012-06-13 7:42 ` [PATCH v8 0/8] x86 TLB flush range optimizing Alex Shi
2012-06-21 5:27 ` Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120613145656.GB32604@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=aarcange@redhat.com \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@intel.com \
--cc=arnd@arndb.de \
--cc=avi@redhat.com \
--cc=borislav.petkov@amd.com \
--cc=cl@gentwo.org \
--cc=cpw@sgi.com \
--cc=eric.dumazet@gmail.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jbeulich@suse.com \
--cc=jeremy@goop.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@mit.edu \
--cc=mingo@redhat.com \
--cc=penberg@kernel.org \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=steiner@sgi.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=tony.luck@intel.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox