public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ben Minerds <puzzleduck@gmail.com>
Cc: alan@lxorguk.ukuu.org.uk, richard.weinberger@gmail.com,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] USB: serial: Changes to conform with checkpatch.sh script.
Date: Wed, 13 Jun 2012 13:35:47 -0700	[thread overview]
Message-ID: <20120613203547.GA4742@kroah.com> (raw)
In-Reply-To: <1338214920-32708-1-git-send-email-puzzleduck@gmail.com>

On Tue, May 29, 2012 at 12:21:54AM +1000, Ben Minerds wrote:
> Updated patch series to remove various warnigs and errors when checkpatch script is run against drivers/usb/serial/keyspan.c.
> Previous version was created from Linuses tree, fixed to use linux-next tree.


Please line-wrap your emails.

And for that matter, your subject: lines shouldn't be longer than 72
columns as well.  Please try something better like:
	USB: serial: Keyspan: did something

And put the full description in the body of the changelog commit.

Care to fix these 6 patches up and resend them?  As they are, I can't
accept them unless I edited them by hand, and I don't have the time to
do that right now :(

thanks,

greg k-h

      parent reply	other threads:[~2012-06-13 20:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-28 14:21 [PATCH 0/6] USB: serial: Changes to conform with checkpatch.sh script Ben Minerds
2012-05-28 14:21 ` [PATCH 1/6] USB: serial: Changes to conform with checkpatch.sh script. - no space before tabs Ben Minerds
2012-05-28 14:21 ` [PATCH 2/6] USB: serial: Changes to conform with checkpatch.sh script. - spaces around '?' and ':' Ben Minerds
2012-05-28 14:21 ` [PATCH 3/6] USB: serial: Changes to conform with checkpatch.sh script. - space around '=' Ben Minerds
2012-05-28 14:21 ` [PATCH 4/6] USB: serial: Changes to conform with checkpatch.sh script. - space near open parenthesis '(' Ben Minerds
2012-05-28 14:21 ` [PATCH 5/6] USB: serial: Changes to conform with checkpatch.sh script. - trailing whitespace Ben Minerds
2012-05-28 14:22 ` [PATCH 6/6] USB: serial: Changes to conform with checkpatch.sh script. - return is not a function, parentheses not required Ben Minerds
2012-06-13 20:35 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120613203547.GA4742@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=puzzleduck@gmail.com \
    --cc=richard.weinberger@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox