From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Alessandro Rubini <rubini@gnudd.com>,
linux-kernel@vger.kernel.org,
Giancarlo Asnaghi <giancarlo.asnaghi@st.com>,
Russell King <linux@arm.linux.org.uk>,
Linus Walleij <linus.walleij@stericsson.com>,
Srinidhi Kasagar <srinidhi.kasagar@stericsson.com>,
Wolfram Sang <w.sang@pengutronix.de>,
Jean Delvare <khali@linux-fr.org>,
linux-i2c@vger.kernel.org, STEricsson_nomadik_linux@list.st.com,
Lee Jones <lee.jones@linaro.org>, Alan Cox <alan@linux.intel.com>
Subject: Re: [PATCH V3 2/3] i2c-nomadik: turn the platform driver to an amba driver
Date: Thu, 14 Jun 2012 08:04:38 +0000 [thread overview]
Message-ID: <201206140804.39083.arnd@arndb.de> (raw)
In-Reply-To: <4a198618063924b68182279ffd56c335d621f542.1339447570.git.rubini@gnudd.com>
On Monday 11 June 2012, Alessandro Rubini wrote:
> The i2c-nomadik gateware is really a PrimeCell APB device. By hosting
> the driver under the amba bus we can access it more easily, for
> example using the generic pci-amba driver. The patch also fixes the
> mach-ux500 users, so they register an amba device instead than a
> platform device.
>
> Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
> Acked-by: Giancarlo Asnaghi <giancarlo.asnaghi@st.com>
> Tested-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> arch/arm/mach-ux500/devices-common.h | 22 +----
> drivers/i2c/busses/i2c-nomadik.c | 142 +++++++++++++++++----------------
> 2 files changed, 78 insertions(+), 86 deletions(-)
You change only one half of ux500 here: the part where the device gets defined
statically, but not not the definition in the device-tree.
I think all you need to do is mark the device compatible with primecell
and add an ID if necessary, but we should definitely make sure that that
path still works, because the one you patch is going away.
Arnd
next prev parent reply other threads:[~2012-06-14 8:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 20:56 [PATCH V3 0/3] i2c-nomadik changes Alessandro Rubini
2012-06-11 20:56 ` [PATCH V3 1/3] i2c-nomadik: move header to <linux/platform_data/i2c-nomadik.h> Alessandro Rubini
2012-06-11 20:56 ` [PATCH V3 2/3] i2c-nomadik: turn the platform driver to an amba driver Alessandro Rubini
2012-06-14 8:04 ` Arnd Bergmann [this message]
2012-06-14 8:17 ` Alessandro Rubini
2012-06-14 8:39 ` Lee Jones
2012-06-14 17:25 ` Linus Walleij
2012-06-11 20:56 ` [PATCH V3 3/3] i2c-nomadik: depend on ARM_AMBA, not PLAT_NOMADIK Alessandro Rubini
2012-06-11 21:37 ` [PATCH V3 0/3] i2c-nomadik changes Linus Walleij
2012-07-09 9:48 ` Wolfram Sang
2012-07-09 19:40 ` Linus Walleij
2012-07-09 20:08 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201206140804.39083.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=alan@linux.intel.com \
--cc=giancarlo.asnaghi@st.com \
--cc=khali@linux-fr.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rubini@gnudd.com \
--cc=srinidhi.kasagar@stericsson.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox