From: Fengguang Wu <wfg@linux.intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: automated warning notifications
Date: Fri, 15 Jun 2012 09:48:35 +0800 [thread overview]
Message-ID: <20120615014835.GA5695@localhost> (raw)
In-Reply-To: <20120614172523.GB4400@mwanda>
Hi Dan,
On Thu, Jun 14, 2012 at 08:25:23PM +0300, Dan Carpenter wrote:
> Hi Fengguang,
>
> I also check new static checker warnings and sometimes email people.
That would be nice!
> I wonder if we are duplicating each others work. For example, did
> you send an email asking about the following Sparse warning:
>
> sound/soc/codecs/ab8500-codec.c:1959:53: warning: cast truncates bits from constant value (1013 becomes 13)
I did try sending out sparse warnings to people, some time ago...
> Quite often those messages are false positive and the value is
> truncated deliberately. In this case it looks suspicious and I
> would maybe email about it. If I knew what kind of messages you
> check and which you ignore that would help me.
The lots of false warnings are a big problem. It makes the automated
notification more noises than signals to people. So I end up disabling
the sparse check totally..
These days I only send out gcc errors/warnings to the commit author,
committer, signers and relevant mailing lists reported by
scripts/get_maintainer.pl (but minus LKML).
> Perhaps there is an email list I could subscribe to to see if you
> had already sent a message.
In an average working day, 1-2 build errors will be caught and email
notified. I guess there will be more sparse warnings if it's turned
on.
Perhaps the sparse warnings can be enabled, but only sent to the patch
author. If you and anyone else are interested, they could be sent to
some mailing list, too. One thing I'm sure is, we probably never want
to disturb the busy maintainers with these warnings.
Thanks,
Fengguang
next prev parent reply other threads:[~2012-06-15 1:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 17:25 automated warning notifications Dan Carpenter
2012-06-15 1:48 ` Fengguang Wu [this message]
2012-06-15 7:12 ` Dan Carpenter
2012-06-15 7:58 ` Fengguang Wu
2012-06-15 8:31 ` Josh Triplett
2012-06-15 8:54 ` Fengguang Wu
2012-06-15 16:48 ` Randy Dunlap
2012-06-16 9:17 ` Fengguang Wu
2012-06-16 17:44 ` Randy Dunlap
2012-06-15 10:40 ` Julia Lawall
2012-06-15 11:19 ` Dan Carpenter
2012-06-15 13:33 ` Peter Senna Tschudin
2012-06-15 13:53 ` Dan Carpenter
2012-06-15 15:49 ` Peter Senna Tschudin
2012-06-15 14:34 ` Fengguang Wu
2012-06-16 7:50 ` Cong Wang
2012-06-16 9:01 ` Fengguang Wu
2012-07-02 12:45 ` Dan Carpenter
2012-07-06 3:07 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120615014835.GA5695@localhost \
--to=wfg@linux.intel.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).