From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: "Kim, Milo" <Milo.Kim@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Girdwood, Liam" <lrg@ti.com>
Subject: Re: [PATCH v2] regulator: add new regulator driver for lp872x
Date: Fri, 15 Jun 2012 12:41:25 +0100 [thread overview]
Message-ID: <20120615114125.GC4482@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAF+7xW=Cb3b64khdNsnyfkJiS4Yt+j8tGFQExAoddXrtu=+5=Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 684 bytes --]
On Fri, Jun 15, 2012 at 07:11:48PM +0800, Axel Lin wrote:
> > + ret = gpio_request(gpio, "LP872X DVS");
> devm_gpio_request
Better yet...
> > + gpio_direction_output(gpio, dvs->init_state);
...devm_gpio_request_one().
> > +module_i2c_driver(lp872x_driver);
> I think you need to use subsys_initcall() here.
> Regulators need to be available early in init in order to allow them
> to be available for consumers when requested.
Well, it depends on the regulator. Those with DCDCs that might supply
cpufreq do because cpufreq can't use deferred probes. Others should now
be able to use deferred probes which should removed the need for this.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-06-15 11:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 8:46 [PATCH v2] regulator: add new regulator driver for lp872x Kim, Milo
2012-06-15 11:11 ` Axel Lin
2012-06-15 11:41 ` Mark Brown [this message]
2012-06-19 6:42 ` Kim, Milo
2012-06-15 13:21 ` Mark Brown
2012-06-19 7:01 ` Kim, Milo
2012-06-15 14:50 ` Axel Lin
2012-06-19 6:42 ` Kim, Milo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120615114125.GC4482@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=Milo.Kim@ti.com \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox