Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer

[Ingo Molnar <mingo@kernel.org>]

* Kay Sievers <kay@vrfy.org> wrote:

> On Thu, 2012-06-14 at 17:04 -0700, Greg KH wrote:
> 
> > As no one seems to have responded, care to resend this with a
> > signed-off-by so I can queue it up for 3.6?  If people complain, it can
> > still go to 3.5, but given that no one is saying anything, I guess no
> > one cares...
> 
> Sounds like a good plan. Here it is.
> 
> Thanks,
> Kay
> 
> 
> From: Kay Sievers <kay@vrfy.org>
> Subject: kmsg - kmsg_dump() use iterator to receice log buffer content

typo.

> 
> Provide an iterator to receive the log buffer content, and convert all
> kmsg_dump() user to it.

typo.

> +/**
> + * kmsg_dump_get_line - retrieve one kmsg log line
> + * @dumper: registered kmsg dumper
> + * @syslog: include the "<4>" prefixes
> + * @line: buffer to copy the line to
> + * @size: maximum size of the buffer
> + * @len: length of line placed into buffer
> + *
> + * Start at the beginning of the kmsg buffer, with the oldest kmsg
> + * record, and copy one record into the provided buffer.
> + *
> + * Consecutive calls will return the next available record moving
> + * towards the end of the buffer with the youngest messages.
> + *
> + * A return value of FALSE indicate that there are no more records to
> + * read.

typo.

> + *
> + * Start at the end of the kmsg buffer and fill the provided buffer
> + * with as many of the the *youngest* kmsg records that fit into it.
> + * If the buffer is large enough, all available kmsg records will be
> + * copied with a single call.
> + *
> + * Consecutive calls will fill the buffer with the next block of
> + * available older records, not including the earlier retrieved ones.
> + *
> + * A return value of FALSE indicate that there are no more records to
> + * read.

typo.

Thanks,

	Ingo