Re: [PATCH tip/core/rcu 07/14] key: Remove extraneous parentheses from rcu_assign_keypointer()

Josh Triplett
2012-06-15T20:51:09Z

On Fri, Jun 15, 2012 at 01:13:08PM -0700, Paul E. McKenney wrote:
> From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
>
> This commit removes the extraneous parentheses from rcu_assign_keypointer()
> so that rcu_assign_pointer() can be wrapped in do-while.
>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

> include/linux/key.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/key.h b/include/linux/key.h
> index 4cd22ed..6fafcf4 100644
> --- a/include/linux/key.h
> +++ b/include/linux/key.h
> @@ -303,7 +303,7 @@ static inline bool key_is_instantiated(const struct key *key)
> rwsem_is_locked(&((struct key *)(KEY))->sem)))
>
> #define rcu_assign_keypointer(KEY, PAYLOAD) \
> - (rcu_assign_pointer((KEY)->payload.rcudata, PAYLOAD))
> + rcu_assign_pointer((KEY)->payload.rcudata, PAYLOAD)
>
> #ifdef CONFIG_SYSCTL
> extern ctl_table key_sysctls[];
> --
> 1.7.8
>