Re: [RFC patch V2 2/7] kthread: Implement park/unpark facility

Thomas Gleixner
2012-06-18T08:50:12Z

On Mon, 18 Jun 2012, Namhyung Kim wrote:
> On Fri, 15 Jun 2012 14:13:21 -0000, Thomas Gleixner wrote:
> > To avoid the full teardown/setup of per cpu kthreads in the case of
> > cpu hot(un)plug, provide a facility which allows to put the kthread
> > into a park position and unpark it when the cpu comes online again.
> >
>
> Please see a comment below. Other than that, you can add my
>
> Reviewed-by: Namhyung Kim <namhyung@kernel.org>
>
> if you want.

My pleasure.

>
> > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> > ---
> > include/linux/kthread.h | 11 ++
> > kernel/kthread.c | 184 +++++++++++++++++++++++++++++++++++++++++++-----
> > 2 files changed, 175 insertions(+), 20 deletions(-)
> [snip]
> > /**
> > + * kthread_create_on_cpu - Create a cpu bound kthread
> > + * @threadfn: the function to run until signal_pending(current).
> > + * @data: data ptr for @threadfn.
> > + * @cpu: The cpu on which the thread should be bound,
> > + * @namefmt: printf-style name for the thread.
>
> How about adding a comment that @namefmt can handle a single %u only
> for the cpu number in the current implementation?

Good point!

Thanks for taking your time!

tglx