From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758880Ab2FOXiZ (ORCPT ); Fri, 15 Jun 2012 19:38:25 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:35381 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758549Ab2FOXiX (ORCPT ); Fri, 15 Jun 2012 19:38:23 -0400 X-Originating-IP: 217.70.178.143 X-Originating-IP: 50.43.46.74 Date: Fri, 15 Jun 2012 16:38:01 -0700 From: Josh Triplett To: "Paul E. McKenney" Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca, niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, Valdis.Kletnieks@vt.edu, dhowells@redhat.com, eric.dumazet@gmail.com, darren@dvhart.com, fweisbec@gmail.com, patches@linaro.org, "Paul E. McKenney" Subject: Re: [PATCH tip/core/rcu 11/15] rcu: Add rcu_barrier() statistics to debugfs tracing Message-ID: <20120615233801.GD7613@leaf> References: <20120615210550.GA27506@linux.vnet.ibm.com> <1339794370-28119-1-git-send-email-paulmck@linux.vnet.ibm.com> <1339794370-28119-11-git-send-email-paulmck@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1339794370-28119-11-git-send-email-paulmck@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 15, 2012 at 02:06:06PM -0700, Paul E. McKenney wrote: > From: "Paul E. McKenney" > > This commit adds an rcubarrier file to RCU's debugfs statistical tracing > directory, providing diagnostic information on rcu_barrier(). > > Signed-off-by: Paul E. McKenney > Signed-off-by: Paul E. McKenney Reviewed-by: Josh Triplett > kernel/rcutree_trace.c | 39 +++++++++++++++++++++++++++++++++++++++ > 1 files changed, 39 insertions(+), 0 deletions(-) > > diff --git a/kernel/rcutree_trace.c b/kernel/rcutree_trace.c > index a3556a2..057408b 100644 > --- a/kernel/rcutree_trace.c > +++ b/kernel/rcutree_trace.c > @@ -46,6 +46,40 @@ > #define RCU_TREE_NONCORE > #include "rcutree.h" > > +static void print_rcubarrier(struct seq_file *m, struct rcu_state *rsp) > +{ > + seq_printf(m, "%c bcc: %d nbd: %lu\n", > + rsp->rcu_barrier_in_progress ? 'B' : '.', > + atomic_read(&rsp->barrier_cpu_count), > + rsp->n_barrier_done); > +} > + > +static int show_rcubarrier(struct seq_file *m, void *unused) > +{ > +#ifdef CONFIG_TREE_PREEMPT_RCU > + seq_puts(m, "rcu_preempt: "); > + print_rcubarrier(m, &rcu_preempt_state); > +#endif /* #ifdef CONFIG_TREE_PREEMPT_RCU */ > + seq_puts(m, "rcu_sched: "); > + print_rcubarrier(m, &rcu_sched_state); > + seq_puts(m, "rcu_bh: "); > + print_rcubarrier(m, &rcu_bh_state); > + return 0; > +} > + > +static int rcubarrier_open(struct inode *inode, struct file *file) > +{ > + return single_open(file, show_rcubarrier, NULL); > +} > + > +static const struct file_operations rcubarrier_fops = { > + .owner = THIS_MODULE, > + .open = rcubarrier_open, > + .read = seq_read, > + .llseek = seq_lseek, > + .release = single_release, > +}; > + > #ifdef CONFIG_RCU_BOOST > > static char convert_kthread_status(unsigned int kthread_status) > @@ -453,6 +487,11 @@ static int __init rcutree_trace_init(void) > if (!rcudir) > goto free_out; > > + retval = debugfs_create_file("rcubarrier", 0444, rcudir, > + NULL, &rcubarrier_fops); > + if (!retval) > + goto free_out; > + > retval = debugfs_create_file("rcudata", 0444, rcudir, > NULL, &rcudata_fops); > if (!retval) > -- > 1.7.8 >