From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] regulator: extend the fixed voltage regulator to accept voltage
Date: Mon, 18 Jun 2012 10:41:45 +0100 [thread overview]
Message-ID: <20120618094145.GC3974@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1206181017360.23884@axis700.grange>
[-- Attachment #1: Type: text/plain, Size: 481 bytes --]
On Mon, Jun 18, 2012 at 10:19:42AM +0200, Guennadi Liakhovetski wrote:
> +#define FIXED_BASE "fixed-dummy"
> +#define FIXED_NAME FIXED_BASE "-00"
> +
> struct fixed_regulator_data {
> struct fixed_voltage_config cfg;
> struct regulator_init_data init_data;
> struct platform_device pdev;
> + char name[sizeof(FIXED_NAME)];
So, this looks pretty ugly and doesn't seem terribly directly related to
supplying a voltage parameter. Please split it out into a separate
change.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-06-18 9:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 8:19 [PATCH] regulator: extend the fixed voltage regulator to accept voltage Guennadi Liakhovetski
2012-06-18 9:41 ` Mark Brown [this message]
2012-06-18 9:52 ` Guennadi Liakhovetski
2012-06-18 10:06 ` Mark Brown
2012-06-18 10:13 ` Guennadi Liakhovetski
2012-06-18 11:57 ` Mark Brown
2012-06-18 15:57 ` [PATCH 1/2 v2] regulator: support multiple dummy fixed regulators Guennadi Liakhovetski
2012-06-18 15:57 ` [PATCH 2/2 v2] regulator: extend the fixed dummy voltage regulator to accept voltage Guennadi Liakhovetski
2012-06-18 16:20 ` [PATCH 1/2 v2] regulator: support multiple dummy fixed regulators Mark Brown
2012-06-18 16:30 ` Guennadi Liakhovetski
2012-06-18 16:37 ` Mark Brown
2012-06-18 17:13 ` Guennadi Liakhovetski
2012-06-18 17:28 ` Mark Brown
2012-06-19 15:43 ` [PATCH 1/2 v3] " Guennadi Liakhovetski
2012-06-19 15:44 ` [PATCH 2/2 v3] regulator: extend the fixed dummy voltage regulator to accept voltage Guennadi Liakhovetski
2012-06-19 22:28 ` [PATCH 1/2 v3] regulator: support multiple dummy fixed regulators Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120618094145.GC3974@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=g.liakhovetski@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).