From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Yadwinder Singh Brar <yadi.brar01@gmail.com>,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH RFC] regulator: core: Support table based mapping in regulator_set_voltage_time_sel
Date: Mon, 18 Jun 2012 10:58:42 +0100 [thread overview]
Message-ID: <20120618095842.GF3974@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1339985488.11918.3.camel@phoenix>
[-- Attachment #1: Type: text/plain, Size: 424 bytes --]
On Mon, Jun 18, 2012 at 10:11:28AM +0800, Axel Lin wrote:
> For table based mapping, we can calculate voltage difference by below equation:
> abs(rdev->desc->volt_table[new_selector] - rdev->desc->volt_table[old_selector])
I've applied this since it's incrementally an improvement but really the
fix here should be to just do this in terms of list_voltage() - call
that on the two selectors and then do the multiplication.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-06-18 9:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 2:11 [PATCH RFC] regulator: core: Support table based mapping in regulator_set_voltage_time_sel Axel Lin
2012-06-18 9:58 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120618095842.GF3974@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=yadi.brar01@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox