From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] regulator: extend the fixed voltage regulator to accept voltage
Date: Mon, 18 Jun 2012 11:06:57 +0100 [thread overview]
Message-ID: <20120618100657.GG3974@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1206181145520.23884@axis700.grange>
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
On Mon, Jun 18, 2012 at 11:52:13AM +0200, Guennadi Liakhovetski wrote:
> Well, I never insist on being the most advanced aesthetics connaisseur,
> but I think these two changes are related. The point is, that if we want
> to support different voltages, boards will have several of these
> regulators, therefore they'll need different names. We could splt this,
> but just the first part - changing the name - would look kinda pointless
> without the second one, don't you think?
The major point there is I shouldn't be reading the change and going
"hang on, this is talking about names not voltages but the changelog
only mentioned voltages, what's that about then?". The code looked more
complex than I'd expect too. I suspect we should be using kstrdup()...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-06-18 10:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 8:19 [PATCH] regulator: extend the fixed voltage regulator to accept voltage Guennadi Liakhovetski
2012-06-18 9:41 ` Mark Brown
2012-06-18 9:52 ` Guennadi Liakhovetski
2012-06-18 10:06 ` Mark Brown [this message]
2012-06-18 10:13 ` Guennadi Liakhovetski
2012-06-18 11:57 ` Mark Brown
2012-06-18 15:57 ` [PATCH 1/2 v2] regulator: support multiple dummy fixed regulators Guennadi Liakhovetski
2012-06-18 15:57 ` [PATCH 2/2 v2] regulator: extend the fixed dummy voltage regulator to accept voltage Guennadi Liakhovetski
2012-06-18 16:20 ` [PATCH 1/2 v2] regulator: support multiple dummy fixed regulators Mark Brown
2012-06-18 16:30 ` Guennadi Liakhovetski
2012-06-18 16:37 ` Mark Brown
2012-06-18 17:13 ` Guennadi Liakhovetski
2012-06-18 17:28 ` Mark Brown
2012-06-19 15:43 ` [PATCH 1/2 v3] " Guennadi Liakhovetski
2012-06-19 15:44 ` [PATCH 2/2 v3] regulator: extend the fixed dummy voltage regulator to accept voltage Guennadi Liakhovetski
2012-06-19 22:28 ` [PATCH 1/2 v3] regulator: support multiple dummy fixed regulators Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120618100657.GG3974@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=g.liakhovetski@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).