From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Sangbeom Kim <sbkim73@samsung.com>
Cc: sameo@linux.intel.com, "'Liam Girdwood'" <lrg@ti.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/7] regualtor: Add samsung s2mps11 regulator driver
Date: Mon, 18 Jun 2012 13:50:05 +0100 [thread overview]
Message-ID: <20120618125005.GN3974@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <067801cd4d45$a743e820$f5cbb860$@com>
[-- Attachment #1: Type: text/plain, Size: 605 bytes --]
On Mon, Jun 18, 2012 at 08:29:41PM +0900, Sangbeom Kim wrote:
> +static int s2mps11_list_voltage(struct regulator_dev *rdev,
> + unsigned int selector)
> +{
Please take a look at the new helper functions which have been added to
the regulator core for factoring out things like table based and linear
maps. This and quite a bit of the rest of the code can probably be
converted to use those.
> + case S2MPS11_AP_EN32KHZ:
> + mask = 0x01;
> + break;
> + case S2MPS11_CP_EN32KHZ:
> + mask = 0x02;
> + break;
> + case S2MPS11_BT_EN32KHZ:
> + mask = 0x04;
> + break;
Use the clk API for clocks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-06-18 12:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 11:29 [PATCH 6/7] regualtor: Add samsung s2mps11 regulator driver Sangbeom Kim
2012-06-18 12:50 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120618125005.GN3974@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox