From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Sangbeom Kim <sbkim73@samsung.com>
Cc: sameo@linux.intel.com, "'Liam Girdwood'" <lrg@ti.com>,
linux-kernel@vger.kernel.org, sbkim01@gmail.com
Subject: Re: [PATCH 7/7] mfd: s2mps11: Add samsung s2mps11 pmic
Date: Mon, 18 Jun 2012 13:52:32 +0100 [thread overview]
Message-ID: <20120618125232.GO3974@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <067901cd4d45$a949f150$fbddd3f0$@com>
[-- Attachment #1: Type: text/plain, Size: 451 bytes --]
On Mon, Jun 18, 2012 at 08:29:45PM +0900, Sangbeom Kim wrote:
> -struct sec_irq_data {
> - int reg;
> - int mask;
> +static struct sec_irq_data s2mps11_irqs[] = {
> + [S2MPS11_IRQ_PWRONF] = {
> + .reg = 1,
> + .mask = S2MPS11_IRQ_PWRONF_MASK,
> + },
This looks like you should be able to factor this code out into
regmap_irq? Might be worth doing that first before all the renames so
that adding the new PMIC would just be adding some more data.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-06-18 12:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 11:29 [PATCH 7/7] mfd: s2mps11: Add samsung s2mps11 pmic Sangbeom Kim
2012-06-18 12:52 ` Mark Brown [this message]
2012-07-02 14:33 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120618125232.GO3974@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
--cc=sbkim01@gmail.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox