From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Miguel Gómez" <magomez@igalia.com>
Cc: arnaud.patard@rtp-net.org, gregkh@linuxfoundation.org,
aaro.koskinen@iki.fi, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/8] Staging: xgifb: Remove XGIFAIL() macro and its calls.
Date: Mon, 18 Jun 2012 18:04:34 +0300 [thread overview]
Message-ID: <20120618150434.GL4400@mwanda> (raw)
In-Reply-To: <7d6346bfccd6b00f7718b8d4ec9a8543871cf580.1340016625.git.magomez@igalia.com>
On Mon, Jun 18, 2012 at 01:12:03PM +0200, Miguel Gómez wrote:
> --- a/drivers/staging/xgifb/XGI_main_26.c
> +++ b/drivers/staging/xgifb/XGI_main_26.c
> @@ -1376,8 +1376,10 @@ static int XGIfb_check_var(struct fb_var_screeninfo *var, struct fb_info *info)
> vtotal = var->upper_margin + var->yres + var->lower_margin
> + var->vsync_len;
>
> - if (!(htotal) || !(vtotal))
> - XGIFAIL("XGIfb: no valid timing data");
> + if (!(htotal) || !(vtotal)) {
Don't resend this, but next time feel free to write this like:
if (!htotal || !vtotal) {
We do have a one change per patch rule but tiny formatting things
like that don't count as a change.
regards,
dan carpenter
> + pr_debug("XGIfb: no valid timing data\n");
> + return -EINVAL;
> + }
>
> if (var->pixclock && htotal && vtotal) {
> drate = 1000000000 / var->pixclock;
next prev parent reply other threads:[~2012-06-18 15:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 11:11 [PATCH 0/8] Homogenize application output and fix sparse warnings Miguel Gómez
2012-06-18 11:11 ` [PATCH 1/8] Staging: xgifb: reformat module parameter descriptions Miguel Gómez
2012-06-18 11:12 ` [PATCH 2/8] Staging: xgifb: remove DEBUGPRN() macro and its uses Miguel Gómez
2012-06-18 11:12 ` [PATCH 3/8] Staging: xgifb: remove DPRINTK() macro and replace it with pr_debug Miguel Gómez
2012-06-18 14:59 ` Dan Carpenter
2012-06-18 11:12 ` [PATCH 4/8] Staging: xgifb: define real dumpVGAReg() content only in DEBUG mode Miguel Gómez
2012-06-18 11:12 ` [PATCH 5/8] Staging: xgifb: Remove XGIFAIL() macro and its calls Miguel Gómez
2012-06-18 15:04 ` Dan Carpenter [this message]
2012-06-18 15:19 ` Miguel Gómez
2012-06-18 11:12 ` [PATCH 6/8] Staging: xgifb: Remove printk usage Miguel Gómez
2012-06-18 11:12 ` [PATCH 7/8] Staging: xgifb: Fix sparse warnings Miguel Gómez
2012-06-18 11:12 ` [PATCH 8/8] Staging: xgifb: Replace pr_* with dev_* when possible Miguel Gómez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120618150434.GL4400@mwanda \
--to=dan.carpenter@oracle.com \
--cc=aaro.koskinen@iki.fi \
--cc=arnaud.patard@rtp-net.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=magomez@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox