From: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
To: Paul Mundt <lethal@linux-sh.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bug.h: Fix up powerpc build regression.
Date: Tue, 19 Jun 2012 00:27:48 +0530 [thread overview]
Message-ID: <20120618185747.GA727@dirshya.in.ibm.com> (raw)
In-Reply-To: <20120618045417.GB19803@linux-sh.org>
* Paul Mundt <lethal@linux-sh.org> [2012-06-18 13:54:17]:
> The asm-generic/bug.h __ASSEMBLY__ guarding is completely bogus, which
> tripped up the powerpc build when the kernel.h include was added:
>
> In file included from include/asm-generic/bug.h:5:0,
> from arch/powerpc/include/asm/bug.h:127,
> from arch/powerpc/kernel/head_64.S:31:
> include/linux/kernel.h:44:0: warning: "ALIGN" redefined [enabled by default]
> include/linux/linkage.h:57:0: note: this is the location of the previous definition
> include/linux/sysinfo.h: Assembler messages:
> include/linux/sysinfo.h:7: Error: Unrecognized opcode: `struct'
> include/linux/sysinfo.h:8: Error: Unrecognized opcode: `__kernel_long_t'
>
> Moving the __ASSEMBLY__ guard up and stashing the kernel.h include under
> it fixes this up, as well as covering the case the original fix was
> attempting to handle.
>
> Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>
>
Tested-by: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
This build fix works fine for me for powerpc (pseries).
--Vaidy
next prev parent reply other threads:[~2012-06-18 18:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 4:54 [PATCH] bug.h: Fix up powerpc build regression Paul Mundt
2012-06-18 18:57 ` Vaidyanathan Srinivasan [this message]
2012-06-25 9:42 ` [PATCH] bug.h: Fix up x86 " Ingo Molnar
2012-06-25 10:50 ` [PATCH, v2] " Ingo Molnar
2012-06-25 11:41 ` [tip:core/urgent] bug.h: Fix x86 !CONFIG_BUG " tip-bot for Ingo Molnar
2012-06-25 12:00 ` [PATCH] bug.h: Fix up x86 " Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120618185747.GA727@dirshya.in.ibm.com \
--to=svaidy@linux.vnet.ibm.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox