Re: nfs3 problem with -rc{2,3}

[Ken Moffat <zarniwhoop@ntlworld.com>]

On Mon, Jun 18, 2012 at 10:03:24PM +0000, Myklebust, Trond wrote:
> On Mon, 2012-06-18 at 22:53 +0100, Ken Moffat wrote:
> > On Mon, Jun 18, 2012 at 09:05:25PM +0100, Ken Moffat wrote:
> > > 
> > >  I suppose I'll have to enable v4 in my configs.
> > > 
> >  Just to confirm, -rc3 with CONFIG_NFS_V4 added to my original
> > .config appears to work fine on nfs v3.
> > 
> >  I suppose I could apply 4f97615d19c370d1d907ef37f8bcd9c3672851ca on
> > top of the conmits which failed to compile without v4, if it is worth
> > investigating this ?  It certainly fixes the error in fs/nfs/read.c,
> > but I also had:
> > 
> > fs/nfs/direct.c:86:29: error: field ‘ds_cinfo’ has incomplete type
> > 
> >  in 3e9e0ca3 which would still prevent me testing at least some of
> > these commits.  Seems to have been fixed *somewhere* in that series,
> > otherwise 4f97615d would not have compiled.  Any suggestions for
> > that ?  Alternatively would it be useful if I discovered which
> > commits are affected for ds_cinfo, or should I just follow the good
> > Dr.Pangloss and add V4 to my config ? ;-)
> 
> Doesn't 4f97615d19 fix the fs/nfs/direct.c problem too? It should.
> 
> Anyhow, if you can apply that on top of the commits that didn't compile,
> and then continue the bisection, that would be great. We definitely do
> want the !defined(CONFIG_NFS_V4) case to work in 3.5-final...
> 
 OK (I was assuming errors in different places were from different
causes).  I'll do that after I've rerun rc3 without NFS_V4 with
SUNRPC_DEBUG.  Thanks.

ĸen
-- 
das eine Mal als Tragödie, das andere Mal als Farce