Re: [PATCH 1/4] staging: comedi: Kconfig: menuconfig options should be bool not tristate

[Greg KH <gregkh@linuxfoundation.org>]

[-- Attachment #1: Type: text/plain, Size: 1613 bytes --]

On Mon, Jun 18, 2012 at 07:16:10PM -0500, H Hartley Sweeten wrote:
> On Monday, June 18, 2012 4:59 PM, Greg KH wrote:
> > On Fri, Jun 15, 2012 at 03:20:04PM -0700, H Hartley Sweeten wrote:
> >> The menuconfig options to enable the misc, isa, pci, pcmcia, and usb
> >> comedi driver selections should be bool not tristate. They don't
> >> directly affect the building of the kernel they just allow other
> >> options to be selected.
> >> 
> >> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> >> Cc: Ian Abbott <abbotti@mev.co.uk>
> >> Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
> >> ---
> >>  drivers/staging/comedi/Kconfig |   10 +++++-----
> >>  1 files changed, 5 insertions(+), 5 deletions(-)
> >
> > This patch breaks the build for me with lots of the following errors:
> > ERROR: "subdev_8255_init" [drivers/staging/comedi/drivers/adl_pci7296.ko] undefined!
> > ERROR: "subdev_8255_cleanup" [drivers/staging/comedi/drivers/adl_pci7296.ko] undefined!
> 
> Strange. I just applied only this patch and the build still works
> on my system. I don't see any reason why this change of the
> menuconfig options from tristate to bool would cause the
> problem you are seeing.
> 
> I do see a problem in the Kconfig for the adl_pci7296 driver.
> 
> Based on the error message above, it requires COMEDI_8255. But that
> option is not listed as a depends or select. I noticed a couple other
> comedi drivers with the same issue.

Below is the .config I use.  Apply your patch, and select 'y' for the
different options it asks for when running 'make oldconfig' and then see
the build errors.



[-- Attachment #2: .config --]
[-- Type: application/x-config, Size: 110552 bytes --]