From: Dan Carpenter <dan.carpenter@oracle.com>
To: Anton Vorontsov <anton.vorontsov@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kees Cook <keescook@chromium.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
devel@driverdev.osuosl.org, linaro-kernel@lists.linaro.org,
Arnd Bergmann <arnd@arndb.de>,
patches@linaro.org, Marco Stornelli <marco.stornelli@gmail.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-kernel@vger.kernel.org, arve@android.com,
Jesper Juhl <jj@chaosbits.net>,
John Stultz <john.stultz@linaro.org>,
Shuah Khan <shuahkhan@gmail.com>,
Rebecca Schultz Zavin <rebecca@android.com>,
WANG Cong <xiyou.wangcong@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
kernel-team@android.com, Thomas Meyer <thomas@m3y3r.de>
Subject: Re: [PATCH 6/7] pstore/ram: Make ECC size configurable
Date: Tue, 19 Jun 2012 10:16:32 +0300 [thread overview]
Message-ID: <20120619071632.GQ4400@mwanda> (raw)
In-Reply-To: <1340072156-6225-6-git-send-email-anton.vorontsov@linaro.org>
On Mon, Jun 18, 2012 at 07:15:55PM -0700, Anton Vorontsov wrote:
> @@ -478,7 +478,7 @@ static void ramoops_register_dummy(void)
> dummy_data->record_size = record_size;
> dummy_data->console_size = ramoops_console_size;
> dummy_data->dump_oops = dump_oops;
> - dummy_data->ecc = ramoops_ecc;
> + dummy_data->ecc_size = ramoops_ecc == 1 ? 16 : ramoops_ecc;
>
I know it's in the change log, but there should probably be a
comment here as well that 1 and 16 are magic backwards compatability
numbers.
> dummy = platform_device_register_data(NULL, "ramoops", -1,
> dummy_data, sizeof(struct ramoops_platform_data));
regards,
dan carpenter
next prev parent reply other threads:[~2012-06-19 7:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 2:10 [PATCH 0/7] pstore/ram: Early registration and configurable ECC buffers size Anton Vorontsov
2012-06-19 2:15 ` [PATCH 1/7] pstore/ram: Probe as early as possible Anton Vorontsov
2012-06-19 18:40 ` Kees Cook
2012-06-19 2:15 ` [PATCH 2/7] pstore/ram: Fix error handling during przs allocation Anton Vorontsov
2012-06-19 18:40 ` Kees Cook
2012-06-19 2:15 ` [PATCH 3/7] pstore/ram_core: Proper checking for post_init errors (e.g. improper ECC size) Anton Vorontsov
2012-06-19 18:41 ` Kees Cook
2012-06-19 2:15 ` [PATCH 4/7] pstore/ram_core: Better ECC size checking Anton Vorontsov
2012-06-19 18:44 ` Kees Cook
2012-06-19 2:15 ` [PATCH 5/7] pstore/ram_core: Get rid of prz->ecc_symsize and prz->ecc_poly Anton Vorontsov
2012-06-19 2:15 ` [PATCH 6/7] pstore/ram: Make ECC size configurable Anton Vorontsov
2012-06-19 7:16 ` Dan Carpenter [this message]
2012-06-19 2:15 ` [PATCH 7/7] pstore/ram_core: Get rid of prz->ecc enable/disable flag Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120619071632.GQ4400@mwanda \
--to=dan.carpenter@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=anton.vorontsov@linaro.org \
--cc=arnd@arndb.de \
--cc=arve@android.com \
--cc=ccross@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jj@chaosbits.net \
--cc=john.stultz@linaro.org \
--cc=keescook@chromium.org \
--cc=kernel-team@android.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.stornelli@gmail.com \
--cc=patches@linaro.org \
--cc=rebecca@android.com \
--cc=sboyd@codeaurora.org \
--cc=shuahkhan@gmail.com \
--cc=thomas@m3y3r.de \
--cc=tony.luck@intel.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox