From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Rhyland Klein <rklein@nvidia.com>
Cc: "'Nikolaus Voss'" <n.voss@weinmann.de>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/power/sbs-battery.c: don't trigger false supply_changed event
Date: Tue, 19 Jun 2012 20:31:03 -0700 [thread overview]
Message-ID: <20120620033103.GA18365@lizard> (raw)
In-Reply-To: <2C89F4165782854891CDE0F3198B753C14F523E30A@HQMAIL01.nvidia.com>
On Wed, May 09, 2012 at 07:51:05AM -0700, Rhyland Klein wrote:
> On Wed, 2012-05-09 at 2:31, Nikolaus Voss wrote:
> >power_supply_changed() events are triggerd based on the return value
> >of a get_property() call. However the property TECHNOLOGY is
> >hard-coded to LION in this driver, thus always succeeds.
> >
> >So, with the battery removed, this triggers a false battery present
> >uevent. This uevent triggers a new query via power_supply_uevent()
> >which again starts to query all known properties and thus leads to
> >an infinite loop of battery present/not-present uevents.
> >
> >This patch skips the battery presence detection for the hard-coded
> >property TECHNOLOGY.
> >
> >Signed-off-by: Nikolaus Voss <n.voss@weinmann.de>
>
> Acked-by Rhyland Klein <rklein@nvidia.com>
Applied, thanks!
--
Anton Vorontsov
Email: cbouatmailru@gmail.com
prev parent reply other threads:[~2012-06-20 3:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 6:30 [PATCH] drivers/power/sbs-battery.c: don't trigger false supply_changed event Nikolaus Voss
2012-05-09 14:51 ` Rhyland Klein
2012-06-20 3:31 ` Anton Vorontsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120620033103.GA18365@lizard \
--to=cbouatmailru@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=n.voss@weinmann.de \
--cc=rklein@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).