From: Jonathan Nieder <jrnieder@gmail.com>
To: Ming Lei <ming.lei@canonical.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Alan Stern <stern@rowland.harvard.edu>,
stable@vger.kernel.org
Subject: Re: [PATCH] driver core: fix shutdown races with probe/remove(v2)
Date: Wed, 20 Jun 2012 18:33:54 -0500 [thread overview]
Message-ID: <20120620233307.GA3120@burratino> (raw)
In-Reply-To: <20120620223754.GA5864@kroah.com>
Greg Kroah-Hartman wrote:
> On Tue, Jun 19, 2012 at 10:00:36AM +0800, Ming Lei wrote:
>> If Documentation/stable_kernel_rules.txt is the correct doc for stable rule,
>> looks reporter requirement isn't listed in the file, but the below can be found:
>>
>> - No "theoretical race condition" issues, unless an explanation of
>> how the race can be exploited is also provided.
>>
>> so I marked it as -stable because I have explained how the race can be
>> exploited in reality.
>
> Ok, but as this has been there since when, 2.5, I'll refrain from
> marking it this way, as no one has reported a real problem like this
> before.
Just to clarify, if I understand correctly, exploited != reproduced. :)
That is, if you have an example of how the race can be exploited by an
unprivileged prankster to make a sysadmin's life miserable, that would
definitely be real problem. On the other hand, if you have a test case
for a rare race condition that has not appeared in the wild and is not
exploitable, that's very useful (test cases make programming much
easier!) but it doesn't make it qualify for stable.
Hope that helps,
Jonathan
next prev parent reply other threads:[~2012-06-20 23:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 5:13 [PATCH] driver core: fix shutdown races with probe/remove(v2) Ming Lei
2012-06-11 14:16 ` Alan Stern
2012-06-11 14:43 ` Ming Lei
2012-06-11 16:02 ` Alan Stern
2012-06-12 1:02 ` Ming Lei
2012-06-15 22:03 ` Greg Kroah-Hartman
2012-06-18 1:52 ` Ming Lei
2012-06-18 22:25 ` Greg Kroah-Hartman
2012-06-19 2:00 ` Ming Lei
2012-06-20 22:37 ` Greg Kroah-Hartman
2012-06-20 23:33 ` Jonathan Nieder [this message]
2012-06-21 1:21 ` Ming Lei
2012-06-21 13:49 ` Greg Kroah-Hartman
2012-06-21 16:04 ` Ming Lei
2012-06-21 16:12 ` Alan Stern
2012-06-21 16:21 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120620233307.GA3120@burratino \
--to=jrnieder@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=stable@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox