linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Cc: Alexis Cortes <alexis.cortes@ti.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "'Quach,
	Brian'" <brian.quach@ti.com>,
	"'Llamas, Jorge'" <jorge.llamas@ti.com>
Subject: Re: [PATCH] usb: host: xhci: Compliance Mode port recovery
Date: Wed, 20 Jun 2012 17:32:32 -0700	[thread overview]
Message-ID: <20120621003232.GD3255@kroah.com> (raw)
In-Reply-To: <20120621000734.GB32743@xanatos>

On Wed, Jun 20, 2012 at 05:07:34PM -0700, Sarah Sharp wrote:
> > Unfortunately there is not a way to programmatically detect if the re-driver
> > is present on the system, and since it might affect any host controller, I'm
> > afraid this workaround can't be limited on the driver to specific hardware. 
> 
> Ok, then make it a module parameter that is off by default.  Users who
> find they have this issue can reload the driver with the timer on, and
> add the module parameter to their grub linux boot line.  If we find that
> the redriver is used always for one particular host vendor/revision,
> we'll add a quirk for it.
> 
> But I really don't want an extra timer running and killing power
> management for hosts that don't need this work around.

I don't want that either, but I really don't want a new module parameter
that no one is going to know that they need to set.

I think the real solution is finding what pci devices this is a problem
with, and using a quirk that way.

thanks,

greg k-h

  reply	other threads:[~2012-06-21  0:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <002801cd4e68$a4b4f3a0$ee1edae0$@cortes@ti.com>
2012-06-19 22:39 ` [PATCH] usb: host: xhci: Compliance Mode port recovery Sarah Sharp
     [not found]   ` <004101cd4f33$755e8eb0$601bac10$@cortes@ti.com>
2012-06-21  0:07     ` Sarah Sharp
2012-06-21  0:32       ` Greg KH [this message]
     [not found]         ` <003001cd4fd3$a7648950$f62d9bf0$@cortes@ti.com>
2012-06-22  0:08           ` Sarah Sharp
2012-06-22  1:48             ` 'Greg KH'
2012-06-22 16:44               ` Sarah Sharp
     [not found]         ` <4fe35a44.82143c0a.4e83.62a8SMTPIN_ADDED@mx.google.com>
2012-06-22  1:40           ` 'Greg KH'
     [not found]       ` <003701cd4fde$fd969290$f8c3b7b0$@cortes@ti.com>
2012-06-22 16:32         ` Sarah Sharp
2012-06-22 16:47           ` Greg KH
     [not found]             ` <4fe9f0c8.04c1b60a.11cc.3ca4SMTPIN_ADDED@mx.google.com>
2012-06-26 17:51               ` 'Greg KH'
     [not found]                 ` <4ffcad84.6710b60a.2b1a.0065SMTPIN_ADDED@mx.google.com>
2012-07-11 15:06                   ` 'Greg KH'
     [not found]                     ` <5016ed18.0730b60a.1211.ffffe227SMTPIN_ADDED@mx.google.com>
2012-07-30 21:47                       ` 'Greg KH'

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120621003232.GD3255@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alexis.cortes@ti.com \
    --cc=brian.quach@ti.com \
    --cc=jorge.llamas@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sarah.a.sharp@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).