From: Ingo Molnar <mingo@kernel.org>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Jeff Epler <jepler@inetnebr.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] x86: boot: Remove ancient dead code
Date: Thu, 21 Jun 2012 07:46:01 +0200 [thread overview]
Message-ID: <20120621054601.GA20066@gmail.com> (raw)
In-Reply-To: <1340230589.1773.7.camel@x61.thuisdomein>
* Paul Bolle <pebolle@tiscali.nl> wrote:
> Release v1.3.82 wrapped a few lines of code in an "#ifdef
> SAFE_RESET_DISK_CONTROLLER" and "#endif" pair. Since
> SAFE_RESET_DISK_CONTROLLER was never defined anywhere that was basically
> a verbose "#ifdef 0" and "#endif" pair. These dead lines have been in
> the tree for sixteen years but now the time has come to remove them.
>
> I guess the main lesson here is that if you want your dead code in the
> tree for a very long time you'd better be creative. A plain old "#ifdef
> 0" and "#endif" pair just doesn't cut it!
and putting it into assembly code is also key to success!
Thanks,
Ingo
prev parent reply other threads:[~2012-06-21 5:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 22:16 [PATCH] x86: boot: Remove ancient dead code Paul Bolle
2012-06-20 22:23 ` Jesper Juhl
2012-06-20 23:02 ` Jeff Epler
2012-06-21 0:38 ` [tip:x86/cleanups] x86, boot: Remove ancient, unconditionally #ifdef'd out " tip-bot for Paul Bolle
2012-06-21 5:46 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120621054601.GA20066@gmail.com \
--to=mingo@kernel.org \
--cc=hpa@zytor.com \
--cc=jepler@inetnebr.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pebolle@tiscali.nl \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).